Bug 186880 - Can't Delete All Local Connections
Summary: Can't Delete All Local Connections
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-14 16:52 EDT by Kevin Doyle CLA
Modified: 2008-08-13 13:18 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Doyle CLA 2007-05-14 16:52:55 EDT 
Since you can run RSE-core without having local plugin installed, you should be able to delete all Local connections.

-----------Enter bugs above this line-----------
TM 2.0M7 Testing
installation : eclipse-SDK-3.3M7
RSE install  : I20070514-1000
java.runtime : Sun 1.5.0_11-b03
os.name:     : Windows XP, Service Pack 2
------------------------------------------------
Comment 1 David McKnight CLA 2007-05-14 16:57:59 EDT 
Historically, local was used to do some of the remote file transfer work however that dependency has been eliminated such that we can get rid of the code that prevents local deletion.  Also because local is always connected, we need special handling to allow a connected local to be deleted (whereas connected remotes can't be deleted).
Comment 2 David McKnight CLA 2007-05-14 17:00:43 EDT 
This is now fixed.
Comment 3 Martin Oberhuber CLA 2007-05-15 04:58:05 EDT 
I don't think this fix is a good idea, I'd prefer closing this as WONTFIX since I think it makes sense to not allow deleting Local connections.

Most people do want or need the "Local" connection in order to
 - browse into archives
 - copy&paste, drag&drop to files or folders outside the workspace
When "Local" is deleted accidentally, it is not obvious how to get it again and the user is lost.

I'd prefer a solution where
1. Local cannot be deleted
2. The Local connection is not auto generated when no subsystem is registered
   against Local (note that the newwizard also won't show local when no 
   subsystems are registered against it; this would better fix the original
   request on this bug)
3. If a subsystem is registered against Local at a later time (e.g. adding
   the Local plugin through update manager), the Local connection should be
   autocreated now; i.e. RSE should check whether Local is there at every
   system startup
4. (optional, not sure) the Local connection should not be shown in the new
   wizard since I cannot see any good use for creating it. Who would want to
   see multiple different "Local" connections? Perhaps with different filters?
   Wouldn't it be better to organize filters in filter pools if this is really
   needed?

I'm not releasing the fix for now; if somebody wants to test it, it is in HEAD and the recent N-build but not in any I-build.

Reopening the bug for comments.
Comment 4 David McKnight CLA 2007-05-15 16:13:00 EDT 
As per today's discussion, to keep local consistent with other types of connections, we elected to allow deletion of all local connections.
Comment 5 Kevin Doyle CLA 2007-05-21 14:40:59 EDT 
Verified with 2.0M7.
Comment 6 Martin Oberhuber CLA 2008-08-13 13:18:36 EDT 
[target cleanup] 2.0 M7 was the original target milestone for this bug