Community
Participate
Working Groups
'Validate' action has disappeared from workbench menu without any reason; contribution has not changed and there were no exceptions in error log. After debugging for some time I've discovered that NPE happens in TaiPanDiagramActionBarContributor but: 1. It was not reported since org.eclipse.gmf.runtime.common.core.util.Trace.catching() reports exceptions only when 'debug' option is set in tracing options and tracing is enabled; that's wrong because exceptions should always be reported! 2. Further processing was stopped so contributions from other providers were not visible. So: always report exceptions that happen in error log and make contribution service more reliable.
Exceptions should be calling org.eclipse.gmf.runtime.common.core.util.Log which log to the log file. Is this not the case in one of the GMF Services? Is the issue still the TaiPan example? How can we duplicate the issue?
You may replicate that in logic sample - open FontStyleAction and add code that throws exception: for example set 'action' to null in createBoldFontStyleAction(...). As a result 'Diagram' menu completely disappears without any messages in error log. If you don't like FontStyleAction you may contribute arbitrary action that causes exception to replicate the issue. The idea of this request is that org.eclipse.gmf.runtime.common.core.util.Trace.catching() should be removed completely since it's dangerous to hide errors.
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug
