Bug 186760 - Two cases of switch in DeltaProcessor#fire could be merged
Summary: Two cases of switch in DeltaProcessor#fire could be merged
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-14 06:00 EDT by Maxime Daniel CLA
Modified: 2007-08-03 11:17 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2007-05-14 06:00:44 EDT
Source based, circa v_758.
DeltaProcessor#1347 and following lines read:
		switch (eventType) {
			case DEFAULT_CHANGE_EVENT:
				firePostChangeDelta(deltaToNotify, listeners, listenerMask, listenerCount);
				fireReconcileDelta(listeners, listenerMask, listenerCount);
				break;
			case ElementChangedEvent.POST_CHANGE:
				firePostChangeDelta(deltaToNotify, listeners, listenerMask, listenerCount);
				fireReconcileDelta(listeners, listenerMask, listenerCount);
				break;
		}

The two cases contain the same code. Unless there is a separate reason (design?) to keep these separated, we may consider merging them for conciseness sake.
Comment 1 Jerome Lanneluc CLA 2007-06-28 09:57:38 EDT
Fixed. Released for 3.4M1 in HEAD.
Comment 2 Frederic Fusier CLA 2007-08-03 11:17:41 EDT
Verified (with v_804 code) for 3.4M1 using build I20070802-0800.