Community
Participate
Working Groups
The User Actions contribution must be independent of RSEUIPlugin. Therefore, left-overs of icons for User Actions should be removed from RSEUIPlugin and moved into org.eclipse.rse.useractions. Finding such references should be relatively easy by searching for the String ICON_ in project org.eclipse.rse.useractions: ICON_SYSTEM_COMPILE_ID ICON_SYSTEM_WORKWITHCOMPILECMDS_ID ICON_SYSTEM_WORKWITHNAMEDTYPES_ID ICON_SYSTEM_WORKWITHUSERACTIONS_ID
Lots of SystemMessages and HelpContexts specific to User Actions are also still in RSEUIPlugin and should be removed. These should be local to the useractions plugin.
Removing stuff from ISystemMessages etc. would be an API change that we cannot have for 2.0.1 -- either we manage getting rid of the stuff now, or we do it in the "Future" main stream.
Martin -- You are correct. In going over the validators I found several that could be moved easily. I'll see how much we can accomplish for RC2 here. -- Dave
Created attachment 70011 [details] patch that removes the user defined actions API from core and ui plugins The patch removes almost all the API for user defined actions from the core and ui plugins. Message IDs, Event resource types, and Icon constants have moved to the user actions plugin. In addition, the folder methods for UD, named types and compile commands have been removed from the SystemResourceManager. The patch does not show the 8 graphic files that will be moved: compile.gif, workwithcompilecmds.gif, workwithnamedtypes.gif, and workwithuseractions.gif, each one from the dlcl16 and elcl16 directories. Most changes are in the useractions plugin itself where the code was impacted by the move of the constants. Although there is quite a lot in this patch, it is relatively safe to apply since the code impacted was not being run.
Created attachment 70021 [details] patch that removes the user defined actions API from core and ui plugins replaces the previous patch - includes copyright information
Kushal - please review. Thanks!
Changes look good to me. Can we take out the commented out code in SystemCommandEditor?
(In reply to comment #7) > Changes look good to me. Can we take out the commented out code in > SystemCommandEditor? > As much as I'm in favor of removing commented out code, I think we need to keep this one since we'll have to find a substitute scheme for doing a callback. At that point it can be deleted.
Committed as reviewed and tested after double checking copyright dates.
Dave -- from ISystemMessages.java, you removed the constants for messages group "G", number 1140-1141, 1180-1191, 1195-1199, 1230-1231. But in systemmessages.xml these are still there, and also in uiMessages.html. Is this intentional? I filed bug #190991 for removal of these.
Yes, this was intentional. The messages file itself is not API and leaving the messages there for now won't hurt. I didn't want to create a new messages file in user actions at this time and trigger a panic for the those who are translating. We can move them in next release so having the new bug report is good.
[target cleanup] 2.0 RC2 was the original target milestone for this bug
