Bug 186569 - Connect is done on main thread for right-click > Launch Shell
Summary: Connect is done on main thread for right-click > Launch Shell
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 2.0   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 186570
  Show dependency tree
 
Reported: 2007-05-11 10:33 EDT by Martin Oberhuber CLA
Modified: 2008-08-13 13:18 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-05-11 10:33:55 EDT 
Select an SSH or Telnet shell subsystem, and choose right-click > Launch Shell.

Tracing shows that the connect call is made on the main (UI) Thread, which means that it can block the entire Eclipse IDE in case anything goes wrong.

Connect should ALWAYS be done on a background thread. The relevant APIs should make sure that it can NEVER happen on a UI thread.

This is a major problem since it can easily block the entire IDE. It's most easily reproducable with a Telnet connection when an invalid user id or password is specified.
Comment 1 David McKnight CLA 2007-05-11 11:29:45 EDT 
I've changed this so that the connect runs in a job.
Comment 2 Martin Oberhuber CLA 2008-08-13 13:18:30 EDT 
[target cleanup] 2.0 M7 was the original target milestone for this bug