Bug 186540 - [search] engine should allocate progress monitor ticks for reporting package declarations
Summary: [search] engine should allocate progress monitor ticks for reporting package ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-11 06:20 EDT by Martin Aeschlimann CLA
Modified: 2008-02-05 04:47 EST (History)
1 user (show)

See Also:

Attachments
Proposed patch (9.31 KB, patch)
2008-01-15 05:07 EST, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2007-05-11 06:20:08 EDT 
3.3 My

see bug 185452: The search engine progress monitor is already on 100% when the results are passed to the search requestor. If should allocated some ticks for the reporting and also test if the monitor got canceled while reporting.
100% should only be reached when all matches are reported.
Comment 1 Frederic Fusier CLA 2008-01-11 05:30:42 EST 
Search Engine already allows progress while locating matches (see MatchLocator.locateMatches(SearchDocument[]) method). This problem is specific while searching for package declarations which does not manage the progress monitor (see MatchLocator.locatePackageDeclarations(SearchParticipant).

=> modify the bug summary
Comment 2 Frederic Fusier CLA 2008-01-15 05:07:50 EST 
Created attachment 86924 [details]
Proposed patch
Comment 3 Frederic Fusier CLA 2008-01-15 05:08:24 EST 
Released for 3.4M5 in HEAD stream.
Comment 4 David Audel CLA 2008-02-05 04:47:28 EST 
Verified for 3.4M5 using build I20080204-0010.