Bug 186459 - Complete Externalization of Strings
Summary: Complete Externalization of Strings
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: JSF Tools (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: 3.1 M4   Edit
Assignee: Debajit Adhikary CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
: 244646 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-05-10 16:57 EDT by Gerry Kessler CLA
Modified: 2009-03-09 17:30 EDT (History)
3 users (show)

See Also:


Attachments
Patch for Strings Externalized so far (74.18 KB, patch)
2008-04-23 17:52 EDT, Debajit Adhikary CLA
no flags Details | Diff
Patch for complete externalization of strings (236.99 KB, patch)
2008-05-06 17:22 EDT, Debajit Adhikary CLA
no flags Details | Diff
Updated patch (247.81 KB, application/x-zip-compressed)
2008-05-08 17:53 EDT, Gerry Kessler CLA
no flags Details
Updated Patch to Externalize all Strings (243.72 KB, patch)
2008-06-30 16:15 EDT, Debajit Adhikary CLA
bjorn.freeman-benson: iplog+
Details | Diff
Patch for string externalization (269.85 KB, patch)
2008-11-12 21:20 EST, Debajit Adhikary CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry Kessler CLA 2007-05-10 16:57:13 EDT
As of 5/10/07, Eclipse tools report that there are 8,657 strings remaining to be externalized in our non-test plugins.   The vast majority are likely do not require externalization, but there may be dozens that do.   In any case, we need to go through them all and mark NLS or NON-NLS.
Comment 1 Raghunathan Srinivasan CLA 2007-05-14 18:58:05 EDT
Consider for 3.0
Comment 2 Raghunathan Srinivasan CLA 2008-03-27 20:31:51 EDT
Gerry will help and apply the patch
Comment 3 Debajit Adhikary CLA 2008-04-23 17:52:16 EDT
Created attachment 97323 [details]
Patch for Strings Externalized so far
Comment 4 Debajit Adhikary CLA 2008-04-23 17:56:28 EDT
Please review the patch for the strings externalized so far.

(As per my discussion with Raghu, this patch (for M7) is only for the strings externalized so far. Many strings still remain to be externalized)
Comment 5 Raghunathan Srinivasan CLA 2008-04-25 17:10:34 EDT
First iteration completed in M7.
Comment 6 Debajit Adhikary CLA 2008-05-06 17:22:54 EDT
Created attachment 98958 [details]
Patch for complete externalization of strings


Please review this patch for complete externalization of strings
(the patch is zipped as Bugzilla wouldn't allow any attachments larger than 2M)
Comment 7 Gerry Kessler CLA 2008-05-08 17:53:19 EDT
Created attachment 99389 [details]
Updated patch
Comment 8 Raghunathan Srinivasan CLA 2008-05-15 15:56:42 EDT
Deferred since this is a significant change.
Comment 9 Debajit Adhikary CLA 2008-06-30 16:15:00 EDT
Created attachment 106152 [details]
Updated Patch to Externalize all Strings

Combines the previous patch and the other string-externalization fixes (TVT fixes etc.) that went into Ganymede
Comment 10 Debajit Adhikary CLA 2008-11-12 21:20:10 EST
Created attachment 117731 [details]
Patch for string externalization

Patch for string externalization. (All user strings have been externalized using Eclipse's NLS string externalization)

Files in the zipped patch:

01 Patch for org.eclipse.jst.jsf.apache.trinidad.tagsupport
02 Patch for org.eclipse.jst.jsf.common
03 Patch for org.eclipse.jst.jsf.common.runtime
04 Patch for org.eclipse.jst.jsf.common.ui
05 Patch for org.eclipse.jst.jsf.core
06 Patch for org.eclipse.jst.jsf.facesconfig
07 Patch for org.eclipse.jst.jsf.facesconfig.ui
08 Patch for org.eclipse.jst.jsf.standard.tagsupport
09 Patch for org.eclipse.jst.jsf.ui
10 Patch for org.eclipse.jst.pagedesigner
11 Patch for org.eclipse.jst.pagedesigner.jsf.ui
12 Patch for org.eclipse.jst.pagedesigner.jsp.core


Verification:

* I ran all the JUnit tests in HEAD/org.eclipse.jsf/.../tests. 
  All tests were successful.

* I did a smoke test with the resulting Eclipse application, 
  and was able to successfully create a JSF application.
Comment 11 Debajit Adhikary CLA 2008-11-12 21:44:33 EST
Comment on attachment 117731 [details]
Patch for string externalization

(The above patch (Attachment 117731 [details]) also updates all plugin settings to flag all non-externalized string literals as errors)
Comment 12 Debajit Adhikary CLA 2008-11-24 16:24:54 EST
The code changes have been checked in to Head.
Comment 13 Gerry Kessler CLA 2009-03-09 17:30:20 EDT
*** Bug 244646 has been marked as a duplicate of this bug. ***