Bug 186456 - [acc] WCAG 2.0 violations in the Web services explorer
Summary: [acc] WCAG 2.0 violations in the Web services explorer
Status: RESOLVED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0.1   Edit
Assignee: Andrew Mak CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-10 16:25 EDT by Peter Moogk CLA
Modified: 2009-02-11 21:55 EST (History)
1 user (show)

See Also:


Attachments
WebKing violation report (84.24 KB, text/html)
2007-05-10 16:26 EDT, Peter Moogk CLA
no flags Details
patch (70.66 KB, patch)
2008-03-19 19:10 EDT, Andrew Mak CLA
no flags Details | Diff
missed a few (73.86 KB, patch)
2008-03-19 19:25 EDT, Andrew Mak CLA
no flags Details | Diff
updated patch (76.79 KB, patch)
2008-03-24 10:01 EDT, Andrew Mak CLA
no flags Details | Diff
updated patch (250.41 KB, patch)
2008-03-24 11:49 EDT, Andrew Mak CLA
bjorn.freeman-benson: iplog+
Details | Diff
wcag report (24.13 KB, text/html)
2008-06-18 14:32 EDT, Peter Moogk CLA
no flags Details
This patch fixes the errors with wsdl_content.jsp (2.33 KB, text/plain)
2008-06-18 15:59 EDT, Andrew Mak CLA
no flags Details
fixes the errors with wsdl_content.jsp (revised) (3.54 KB, patch)
2008-06-18 16:21 EDT, Andrew Mak CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Moogk CLA 2007-05-10 16:25:14 EDT
The current accessiblity check list requires that we be WCAG 2.0 compliant for our web pages.  Since, we have added some new SOAP header funcationality into the Web services explorer, I used the WebKing tool to verify compliance with WCAG 2.0.  Unfortunately, the tools spit out a report with over 100 violations.
I will attach the generated report to this defect.

Note: this report only show violations for web pages traversed while testing the new SOAP header funcationity.  If other parts of the explorer were traversed many more violations would probably be found.
Comment 1 Peter Moogk CLA 2007-05-10 16:26:28 EDT
Created attachment 66774 [details]
WebKing violation report
Comment 2 Chris Brealey CLA 2007-05-11 09:22:31 EDT
Gil,
from a glance at the report, we will have to deal with a very large number of repetitive but uncomplicated changes such as the addition of translatable alt text to img elements. This may also affect some CTOR signatures where we currently pass only an image string. I have not found the source of the doctype and lang violations, however, I'm guessing these might be fixed in a single spot as they have been flagged in just about every JSP Peter exercised, and with very few exceptions always on line 6.

Peter or David,
do all these violations need to be fixed in order to release WTP 2.0? I'm concerned not just with the scope of the changes that will be necessary, but with what I expect is the requirement to provide translatable property text for all img elements. As far as I know, we are past the point in WTP 2.0 where we should be adding translatable properties on this scale.

Targetted to 2.0 (no RC) pending a bit more discussion on whether this can be contained at all in 2.0.
Comment 3 John Lanuti CLA 2007-05-15 13:55:49 EDT
Assuming this does not prohibit any function we should defer this defect to 2.0.1.  We should not be making large scale UI changes at this point in 2.0.
Comment 4 Chris Brealey CLA 2007-05-15 16:30:39 EDT
Deferred to 2.0.1 per comment 3.
Comment 5 Kathy Chan CLA 2007-08-10 08:57:36 EDT
Defering to WTP 3.0.
Comment 6 Kathy Chan CLA 2008-02-19 13:37:56 EST
As this will hit the properties files, we need to address it for M6.
Comment 7 Kathy Chan CLA 2008-03-11 09:41:48 EDT
Trung, please take a look at this accessibility violation for M6.  You can get more info about the nature of the violation from Peter or Zina.  Then you can talk to Gil to have some pointers of how to fix up the WSE for this problem.  Thanks!
Comment 8 Kathy Chan CLA 2008-03-16 12:13:00 EDT
Over to you to handle as you are more familiar with the WSE.  Please note that it needs to be addressed for M6 because of properties files changes.
Comment 9 Andrew Mak CLA 2008-03-19 19:10:35 EDT
Created attachment 92974 [details]
patch

This is a partial fix of errors about missing alt tags.  I've examined the images used in WSE, the ones that are missing alt tags are mainly trivial images such as spacers and lines, or icons appearing beside a title.  For these cases, the null alt attribute should be used (alt="") so that the image will be ignored by assistive technologies.
Comment 10 Andrew Mak CLA 2008-03-19 19:25:42 EDT
Created attachment 92976 [details]
missed a few
Comment 11 Andrew Mak CLA 2008-03-24 10:01:40 EDT
Created attachment 93269 [details]
updated patch
Comment 12 Andrew Mak CLA 2008-03-24 11:49:52 EDT
Created attachment 93283 [details]
updated patch

fixes doctype and lang violations as well
Comment 13 Kathy Chan CLA 2008-03-24 17:31:57 EDT
Patch committed to HEAD and released to WTP 3.0 as v200803242129.  Thanks Andrew for handling!
Comment 14 David Williams CLA 2008-04-24 00:45:09 EDT
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword. 
Comment 15 Peter Moogk CLA 2008-06-18 14:32:15 EDT
Created attachment 105330 [details]
wcag report
Comment 16 Peter Moogk CLA 2008-06-18 14:34:11 EDT
The number of WCAG problems has definitely gone down, however, there are still some outstanding issues.  Please, see the latest wcag report that I have attached to this defect.  Thanks.
Comment 17 Andrew Mak CLA 2008-06-18 15:59:41 EDT
Created attachment 105337 [details]
This patch fixes the errors with wsdl_content.jsp
Comment 18 Andrew Mak CLA 2008-06-18 16:21:59 EDT
Created attachment 105340 [details]
fixes the errors with wsdl_content.jsp (revised)
Comment 19 Andrew Mak CLA 2008-06-18 16:37:19 EDT
The rest of the errors only show up when checking against section 508 rules, which I believe are part of an old version of the web accessibility guidelines.  They do not show up when checking against newer WCAG 2.0 rules.
Comment 20 Kathy Chan CLA 2008-06-18 21:25:19 EDT
Patch committed and released to WTP 3.0.1 as v200806182255.
Comment 21 Kathy Chan CLA 2008-10-27 14:18:02 EDT
This defect has been in resolve state for a while.  Please verify this with the appropriate WTP driver which can be found in:

http://download.eclipse.org/webtools/downloads/

We would verify and close the defect on the originator's behalf if it has not been verified 2 weeks after it's been changed to Verified state.
Comment 22 Kathy Chan CLA 2009-02-11 21:55:35 EST
This bug has been in resolved state for a while.  Please verify this defect with the latest WTP 3.0.4 or WTP 3.5 build from:

http://download.eclipse.org/webtools/downloads/

If this is not verified within 2 weeks, we'll be verifying the bug on your behalf.  Thanks!