Bug 186363 - [api][breaking] Get rid of ISubSystem#connect() API without progress or callback
Summary: [api][breaking] Get rid of ISubSystem#connect() API without progress or callback
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.0 M3   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-05-10 10:24 EDT by Martin Oberhuber CLA
Modified: 2007-11-05 11:08 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-05-10 10:24:06 EDT 
Deprecated method ISubSystem#connect() should be removed.
All calls should be replaced by the two new alternatives:

  * Synchronous ISubSystem#connect(IProgressMonitor, boolean)
  * Asynchronous ISubSystem#connect(boolean, IRSECallback)
Comment 1 Martin Oberhuber CLA 2007-05-14 06:29:37 EDT 
Moving to RC1: We'll reserve the right to remove deprecated API even with RC1.
Comment 2 Martin Oberhuber CLA 2007-05-18 16:19:00 EDT 
We should use the new ISubSystem#connect() APIs which take a progress monitor or a callback, depending on what thread we think we are. Access to the deprecated ISubSystem#connect() should be removed.

Assigning RC1 for the simpler work. We'll probably not get all occurrences done and move this out to the future then.
Comment 3 Martin Oberhuber CLA 2007-05-30 13:03:18 EDT 
This seems a sizeable and potentially risky change for RC3. 
I'm ok if we cannot get it done for 2.0.
Comment 4 David McKnight CLA 2007-05-30 13:43:05 EDT 
I imagine this to be fairly straight forward.  Just a matter of replacing obselete connect() calls with the new ones.  I guess it's trickier if we need callbacks.
Comment 5 Martin Oberhuber CLA 2007-10-01 07:57:24 EDT 
Bulk update target milestone 2.0.1 -> 3.0
Comment 6 David McKnight CLA 2007-11-05 10:56:55 EST 
I've removed the deprecated connect() API and replaced all the obsolete calls to use the appropriate alternatives.
Comment 7 Martin Oberhuber CLA 2007-11-05 11:08:18 EST 
Marking as breaking API since deprecated ISubSystem#connect() API was removed.

Clients should use {@link #connect(IProgressMonitor, boolean)} from background
thread, or {@link #connect(boolean, IRSECallback)} from UI thread instead.