Bug 186333 - [search] Should better locate fields and methods matches on binary super types with unresolved references
Summary: [search] Should better locate fields and methods matches on binary super type...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-10 06:47 EDT by Frederic Fusier CLA
Modified: 2007-08-03 09:48 EDT (History)
0 users

See Also:

Attachments
Proposed patch (12.54 KB, patch)
2007-07-18 10:51 EDT, Frederic Fusier CLA 		no flags Details | Diff
Additional patch (18.92 KB, patch)
2007-07-19 11:05 EDT, Frederic Fusier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2007-05-10 06:47:24 EDT 
Follow-up of bug 185036 for search engine.

The patch to fix failing search tests proposed in bug 185036 comment 4 was incorrect.  ClassFileMatchLocator#locateMatches method needs to be improved to continue to report the potential matches of the unresolved references...
Comment 1 Frederic Fusier CLA 2007-07-18 05:10:41 EDT 
The correct reference is bug 185306 instead of 185036!
Comment 2 Frederic Fusier CLA 2007-07-18 10:51:28 EDT 
Created attachment 74058 [details]
Proposed patch
Comment 3 Frederic Fusier CLA 2007-07-18 10:52:40 EDT 
Released for 3.4M1 in HEAD stream.
Comment 4 Frederic Fusier CLA 2007-07-19 11:05:45 EDT 
Created attachment 74161 [details]
Additional patch

Additional patch to fix a problem with accuracy when there's no resolution
+
Lazy initialization of arrays to avoid unnecessary objects creation and copy...
Comment 5 Frederic Fusier CLA 2007-07-19 11:07:48 EDT 
Additional patch released in HEAD.
Comment 6 Frederic Fusier CLA 2007-08-03 09:48:49 EDT 
Verified for 3.4M1 using build I20070802-0800.