Bug 186249 - [GraphLayout] DirectedGraphLayout reassigns width and height
Summary: [GraphLayout] DirectedGraphLayout reassigns width and height
Status: NEW
Alias: None
Product: GEF
Classification: Tools
Component: GEF-Legacy Draw2d (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: gef-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-09 16:25 EDT by Raheel Ashraf CLA
Modified: 2010-11-04 17:20 EDT (History)
3 users (show)

See Also:


Attachments
fix patch + problems that follows from constant size (5.97 KB, patch)
2008-10-03 17:04 EDT, Alex Boyko CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raheel Ashraf CLA 2007-05-09 16:25:32 EDT
After I invoke the layout algorithm (i.e. DirectedGraphLayout), it reassigns the height and width to the node. This makes the graph look and feel inconsistent because all labels (I am drawing the nodes as Labels) now are of different sizes. As a result some of these labels wouldn't even contain the full text. 
Either:
1. There should be a option to specify that the width and height shouldn’t be changed during the layout
2. We shouldn’t preassign the width and height to the nodes and the layout should only take in the information about the available space and use it appropriately
Comment 1 Alex Boyko CLA 2008-10-03 17:04:39 EDT
Created attachment 114228 [details]
fix patch + problems that follows from constant size

The size of nodes may remain constant. The fix for that is attached.
However, you'll get lots of issues with connection routing.
Check out examples I've added to DirectedGraphDemo (from Draw2D examples plugin):
1. constantSizeNodes1 - this one looks good
2. constantSizeNodes_Problems - not so good anymore
Comment 2 Anthony Hunter CLA 2009-03-06 11:35:24 EST
Alex, I think I am confused if we wanted to commit the patch or not, since it does not fix the issue?