Bug 186114 - IMethodBinding.overrides(..) should consider static
Summary: IMethodBinding.overrides(..) should consider static
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3.1   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 183513
  Show dependency tree
 
Reported: 2007-05-09 06:28 EDT by Martin Aeschlimann CLA
Modified: 2008-09-16 09:45 EDT (History)
2 users (show)

See Also:


Attachments
Proposed fix (1.69 KB, patch)
2007-07-17 13:51 EDT, Olivier Thomann CLA
no flags Details | Diff
Regression tests (6.23 KB, patch)
2007-07-17 13:52 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2007-05-09 06:28:08 EDT
20070509

IMethodBinding.overrides(..) returns true here when asked if Y#method overrides X#overrides

public class X {
        public static void method() {
        }
}

class Y extends X {
        public static void method() {
        }
}
Comment 1 Martin Aeschlimann CLA 2007-07-10 09:39:11 EDT
Can we increase the priority here? 
Comment 2 Olivier Thomann CLA 2007-07-17 13:51:20 EDT
Philippe, candidate for 3.3.1 ?
Comment 3 Olivier Thomann CLA 2007-07-17 13:51:44 EDT
Created attachment 73983 [details]
Proposed fix
Comment 4 Olivier Thomann CLA 2007-07-17 13:52:03 EDT
Created attachment 73984 [details]
Regression tests
Comment 5 Olivier Thomann CLA 2007-07-17 13:54:56 EDT
This patch seems to also fix bug 183513.
Comment 6 Olivier Thomann CLA 2007-07-17 13:56:24 EDT
Sorry. I should have asked Jérôme if this is a candidate for 3.3.1.
Jérôme, your call.
Comment 7 Olivier Thomann CLA 2007-07-17 14:08:48 EDT
Released for 3.4M1.
Regression tests added in org.eclipse.jdt.core.tests.dom.ASTConverter15Test#test0277
org.eclipse.jdt.core.tests.dom.ASTConverter15Test#test0278
org.eclipse.jdt.core.tests.dom.ASTConverter15Test#test0279
org.eclipse.jdt.core.tests.dom.ASTConverter15Test#test0280
Comment 8 Jerome Lanneluc CLA 2007-08-09 06:59:21 EDT
+1 for backporting to 3.3.1
Comment 9 Olivier Thomann CLA 2007-08-13 14:59:33 EDT
Reopen for 3.3.1.
Comment 10 Olivier Thomann CLA 2007-08-13 15:00:20 EDT
Released for 3.3.1.
Same regression tests as HEAD stream.
Comment 11 Olivier Thomann CLA 2007-08-13 15:05:30 EDT
Verified for 3.4M1 using I20070809-1105
Comment 12 Eric Jodet CLA 2007-09-03 09:14:40 EDT
Verified for 3.3.1 using build M20070831-2000