Bug 186024 - [Cheatsheet Editor] NPE when registering non-editable model
Summary: [Cheatsheet Editor] NPE when registering non-editable model
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Noam Chitayat CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-08 15:46 EDT by Wassim Melhem CLA
Modified: 2007-06-05 18:55 EDT (History)
1 user (show)

See Also:


Attachments
Patch for bug 186024. (Affects CSAbstractPage.java) (1012 bytes, patch)
2007-05-09 16:37 EDT, Noam Chitayat CLA
wassim.melhem: review?
mike.pawlowski: review+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-05-08 15:46:35 EDT
3.3 M7

Open one of org.eclipse.pde's cheatsheets directly from CVS.

Click on the 'Register this cheatsheet' link in the header.

you get an NPE.  The link should not be there on non-editable cheatsheets.

eclipse.buildId=I20070503-1400
java.version=1.5.0_03
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=en_US
Framework arguments:  -startup D:\Eclipse\eclipse\plugins\org.eclipse.equinox.launcher_1.0.0.v20070502.jar
Command-line arguments:  -os win32 -ws win32 -arch x86 -startup D:\Eclipse\eclipse\plugins\org.eclipse.equinox.launcher_1.0.0.v20070502.jar -data D:\Eclipse\UpdatedSource\plugins

Error
Tue May 08 15:44:18 EDT 2007
Unhandled event loop exception

java.lang.NullPointerException
	at org.eclipse.pde.internal.ui.wizards.cheatsheet.RegisterCSWizardPage.initialize(RegisterCSWizardPage.java:129)
	at org.eclipse.pde.internal.ui.wizards.cheatsheet.RegisterCSWizardPage.<init>(RegisterCSWizardPage.java:108)
	at org.eclipse.pde.internal.ui.wizards.cheatsheet.RegisterCompCSWizardPage.<init>(RegisterCompCSWizardPage.java:26)
	at org.eclipse.pde.internal.ui.wizards.cheatsheet.RegisterCSWizard.addPages(RegisterCSWizard.java:50)
	at org.eclipse.jface.wizard.WizardDialog.createContents(WizardDialog.java:540)
	at org.eclipse.jface.window.Window.create(Window.java:426)
	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1081)
	at org.eclipse.pde.internal.ui.editor.cheatsheet.CSAbstractPage.handleLinkActivatedRegisterCS(CSAbstractPage.java:147)
	at org.eclipse.pde.internal.ui.editor.cheatsheet.CSAbstractPage.access$3(CSAbstractPage.java:140)
	at org.eclipse.pde.internal.ui.editor.cheatsheet.CSAbstractPage$2.linkActivated(CSAbstractPage.java:104)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleActivate(AbstractHyperlink.java:228)
	at org.eclipse.ui.forms.widgets.ImageHyperlink.handleActivate(ImageHyperlink.java:177)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink.handleMouseUp(AbstractHyperlink.java:316)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink.access$2(AbstractHyperlink.java:300)
	at org.eclipse.ui.forms.widgets.AbstractHyperlink$4.handleEvent(AbstractHyperlink.java:119)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3673)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3284)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2365)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2329)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2204)
	at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:153)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.lang.reflect.Method.invoke(Unknown Source)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:497)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:436)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1162)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1137)
Comment 1 Mike Pawlowski CLA 2007-05-08 16:01:07 EDT
Hi Noam, can you take a look at this?  I'll review.
Comment 2 Noam Chitayat CLA 2007-05-09 16:37:59 EDT
Created attachment 66566 [details]
Patch for bug 186024. (Affects CSAbstractPage.java)

If the cheatsheet model is read-only, the "Register this cheat sheet" link is never created.
Comment 3 Mike Pawlowski CLA 2007-05-09 18:19:44 EDT
Patch applied to HEAD.
Tested well.  Good job Noam

Target:  3.3 RC1