Bug 185872 - [introduce parameter object] Introduce Parameter Object cannot create nested class if top-level type with the same name exists
Summary: [introduce parameter object] Introduce Parameter Object cannot create nested ...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Karsten Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-07 19:29 EDT by Missing name Mising name CLA
Modified: 2007-06-06 12:25 EDT (History)
1 user (show)

See Also:
martinae: review+

Attachments
Shows an information if name already exists (3.75 KB, patch)
2007-05-15 09:03 EDT, Karsten Becker CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Missing name Mising name CLA 2007-05-07 19:29:42 EDT 
3.3M7 I20070503-1400

1. Have two source files X.java and Y.java.
2. Perform the Introduce Parameter Object refactoring to a method in X.  Choose to create a nested class and call it Y.
3. The refactoring cannot proceed as the dialogue sees a clash between the existing Y and the proposed X.Y.

The dialogue should only block an attempt to create the top-level Y, not the nested X.Y (providing that the rest of the code can be refactored so that 'Y' refers to the intended class).  The dialogue could warn about the similar name though.
Comment 1 Karsten Becker CLA 2007-05-15 09:03:18 EDT 
Created attachment 67224 [details]
Shows an information if name already exists
Comment 2 Karsten Becker CLA 2007-05-15 09:06:10 EDT 
Please review
Comment 3 Martin Aeschlimann CLA 2007-05-15 09:54:34 EDT 
patch reviewed and released > 20070515
Comment 4 Martin Aeschlimann CLA 2007-05-18 11:43:43 EDT 
verified in 20070517-1700

filed bug 187839 for a smaller issue with default packages