Bug 185734 - [Launcher] eclipse launcher exe is missing for Solaris-Motif
Summary: [Launcher] eclipse launcher exe is missing for Solaris-Motif
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.3   Edit
Hardware: Sun Solaris-Motif
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: equinox.framework-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-07 06:39 EDT by Martin Oberhuber CLA
Modified: 2007-05-08 10:03 EDT (History)
3 users (show)

See Also:
aniefer: review+


Attachments
Patch to support building on Solaris with gcc (4.39 KB, patch)
2007-05-07 06:41 EDT, Martin Oberhuber CLA
no flags Details | Diff
Binaries compiled with gcc-3.4.5 on Solaris9 (35.75 KB, application/x-compressed)
2007-05-07 06:43 EDT, Martin Oberhuber CLA
no flags Details
updated patch (6.75 KB, patch)
2007-05-07 13:29 EDT, Andrew Niefer CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-05-07 06:39:33 EDT
The eclipse Launcher executable and shared library is missing in the CVS Repository for Solaris Motif. I think it should be compiled and added back in order to support Solaris-Motif source builds. Note that SWT is also still being built for Solaris-Motif.

Workaround: Start Eclipse with the Java launcher, like this:
java -jar plugins/[org.eclipse.equinox.launcher_1.0.0.v20070319.jar]

where [org.eclipse.equinox.launcher_1.0.0.v20070319.jar] is replaceable by
whatever launcher jar you have in the current eclipse.
Comment 1 Martin Oberhuber CLA 2007-05-07 06:41:31 EDT
Created attachment 66074 [details]
Patch to support building on Solaris with gcc

Attached patch is needed to support building the Launcher on Solaris with gcc.
Comment 2 Martin Oberhuber CLA 2007-05-07 06:43:36 EDT
Created attachment 66076 [details]
Binaries compiled with gcc-3.4.5 on Solaris9

Attached archive contains the Launcher binaries, compiled with gcc-3.4.5 on
Solaris 9. These should be checked in to CVS.

Build script I used:
--------------------
cd org.eclipse.equinox.executable/library/motif
setenv PATH /Net/szg-rhfs/szg-rhfs3/t5-dev/tools/gcc/3.4.5/SunOS/5.7/bin:$PATH
setenv CC gcc
build.sh -java /usr/j2se

Other Build Info
----------------
My gcc was configured and built on Solaris7 with 
   ./configure --with-dwarf-2 --disable-shared
Comment 3 Martin Oberhuber CLA 2007-05-07 07:01:23 EDT
Kim, what is the status of Solaris-Motif as per Eclipse 3.3 -- is it still included in the source build? Did anybody test it recently?

My company is moving away from Motif, so it's not an issue for us any more, but others may still need it (see bug 169379 comment 3, for instance, which was filed on 27-Apr-2007).
Comment 4 Kim Moir CLA 2007-05-07 09:09:36 EDT
The support is included with the source build but of course, the launcher doesn't exist.  No, it has not been tested recently.  In other cases, for instance, see bug 178905, the equinox team created directories to store the launchers  and asked other teams to contribute the compiled libraries.
Comment 5 Martin Oberhuber CLA 2007-05-07 09:55:22 EDT
FYI, I noticed that my binaries don't run because fixEnvForNetscape() cannot be
resolved. I'm assuming that this was broken due to refactorings -- there is
also fixEnvForMozilla(), and eclipseNix.c references both it and
fixEnvForNetscape().

I'm not sure how this is intended to work, but I assume that a possible fix
would be to just remove the "static" qualifier from fixEnvForNetscape(), such
that it is visible both in the eclipseMotif.c file AND in the eclipseNix.c file
(otherwise, the static qualifier would hide it from ecipseNix.c).
Comment 6 Andrew Niefer CLA 2007-05-07 13:29:29 EDT
Created attachment 66156 [details]
updated patch

Yes, that was a refactoring that was never compiled for solaris.motif.
Comment 7 Andrew Niefer CLA 2007-05-07 13:32:11 EDT
We can compile a solaris motif launcher with little effort.  However, note that it will not be fully tested.
Comment 8 Thomas Watson CLA 2007-05-07 15:52:37 EDT
patch is fine for solaris-motif.  More work is probably needed if we want to build binaries for hpux-motif.
Comment 9 Andrew Niefer CLA 2007-05-07 16:48:47 EDT
done
Comment 10 Martin Oberhuber CLA 2007-05-08 04:38:10 EDT
When trying to run the Solaris Motif Launcher from CVS, I get this message:

%>./eclipse.motif -data ../workspace
You must install a Solaris patch to run the native threads version of the
Java runtime.  The green threads version will work without this patch.
Please check the native threads release notes for more information.

If you are embedding the VM in a native application, please make sure that
the native application is linked with libthread.so (-lthread).

Exiting.

I did not get this message with Eclipse 3.2.1 Solaris-Motif on the same machine, so I think this is a regression and should be fixed. Looks like -lthread should be put on the link line?
Comment 11 Andrew Niefer CLA 2007-05-08 09:42:32 EDT
It was being linked with pthread, and should have been thread.  Change has been made and the binary updated in cvs.
Comment 12 Martin Oberhuber CLA 2007-05-08 10:03:25 EDT
Verified out of CVS: This works fine now on Solaris 9, and even brings up the Workbench on Solaris 7 (with jdk1.4.1_01-b01). Compared to bug 185936, starting with java launcher.jar -showsplash also works properly on Motif (it fails on GTK).

Final verification will be done with the next I-build.

Thanks!!