Bug 185733 - Refreshing external jar doesn't update problem marker
Summary: Refreshing external jar doesn't update problem marker
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-05-07 06:35 EDT by Jerome Lanneluc CLA
Modified: 2007-05-15 05:47 EDT (History)
0 users

See Also:
frederic_fusier: review+

Attachments
Proposed fix and regression tests (4.02 KB, patch)
2007-05-07 08:59 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Fix and regression tests v2 (4.24 KB, patch)
2007-05-09 07:30 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jerome Lanneluc CLA 2007-05-07 06:35:41 EDT 
I20070503-1400

1. Create Java project P
2. Add and external jar (e.g. d:\temp\test.jar) to its build path
3. Rename the external jar on disk
4. Select P and File > Refresh 
Observe: no marker is created to indicate that there is a build path problem
Comment 1 Jerome Lanneluc CLA 2007-05-07 08:59:27 EDT 
Created attachment 66093 [details]
Proposed fix and regression tests
Comment 2 Frederic Fusier CLA 2007-05-09 04:28:30 EDT 
Fix is OK for me.

Just two cosmetic remarks about added tests:
1) I think the 2 tests should be contiguous in the test suite. So if you want to sort tests by names, perhaps it would be better to rename them.
2) Add a assertMarkers before add/remove the external jar would help to better understand how the tests are supposed to work while reading them.
Comment 3 Jerome Lanneluc CLA 2007-05-09 07:30:18 EDT 
Created attachment 66438 [details]
Fix and regression tests v2

The fix is the same as before.
The tests have been renamed so their names are contiguous.
A comment has been added to document what are the markers before the operation (I did not add an assertMarker to keep the spirit of 1 assert per test)
Comment 4 Jerome Lanneluc CLA 2007-05-09 07:32:23 EDT 
Fix and tests released for 3.3RC1 in HEAD.
Comment 5 Maxime Daniel CLA 2007-05-15 05:47:25 EDT 
Verified for 3.3 RC1 using build I20070515-0010.