Bug 185713 - Filter on the New Extension wizard is too strict
Summary: Filter on the New Extension wizard is too strict
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Noam Chitayat CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-05-07 00:43 EDT by Wassim Melhem CLA
Modified: 2007-06-05 18:54 EDT (History)
0 users

See Also:

Attachments
Patch for bug 185713 (Affects PointSelectionPage.java) (992 bytes, patch)
2007-05-08 10:18 EDT, Noam Chitayat CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-05-07 00:43:28 EDT 
Build: 3.3 M7

1. Create a hello world plug-in project

2. On the Extensions page, press Add...

3. In the 'Extension Point Filter' field, type 'o'.

Surprisingly, everything vanishes even though all extension points listed start with 'o'.

This is probably a regression due to fix for bug 148687.

We need to restore the sensible basic behavior above while keeping the enhancement (bug 148687)
Comment 1 Noam Chitayat CLA 2007-05-08 10:18:26 EDT 
Created attachment 66288 [details]
Patch for bug 185713 (Affects PointSelectionPage.java)

As it turns out, whenever the filter gets any text without ".", "*", or "?", we look for anything that contains the filter text preceded by ".". This extra condition has been removed.

In the case of the above example:

Without the patch applied:
Filter matches on "*.o*", which returns nothing.

After the patch:
Filter matches on "*o*", which returns everything.
Comment 2 Wassim Melhem CLA 2007-05-08 10:44:05 EDT 
Patch works well.  Thanks.