Bug 185377 - [introduce parameter object] UI problems
Summary: [introduce parameter object] UI problems
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 RC1   Edit
Assignee: Karsten Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 185332
  Show dependency tree
 
Reported: 2007-05-03 11:51 EDT by Markus Keller CLA
Modified: 2009-06-16 12:38 EDT (History)
1 user (show)

See Also:
martinae: review+

Attachments
Patch for UI Issues (7.31 KB, patch)
2007-05-04 05:32 EDT, Karsten Becker CLA 		no flags Details | Diff
Adopted for current CVS Base (7.31 KB, patch)
2007-05-08 05:07 EDT, Karsten Becker CLA 		no flags Details | Diff
Adopted for current CVS Base (7.31 KB, patch)
2007-05-08 05:08 EDT, Karsten Becker CLA 		no flags Details | Diff
Disable edit if not marked as field (8.24 KB, patch)
2007-05-10 05:40 EDT, Karsten Becker CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-05-03 11:51:49 EDT 
I20070503-0010

- "Select fields for parameter object class:":
  - needs mnemonic that transfers focus into the table
  - add a bit of white space above the label

- Edit dialog:
  - problem: the dialog is used for field names (checked) and for parameter names (unchecked). It should change the names depending on checkbox state.
  - dialog title should be title case and relate to the action that opened it, i.e. "Edit Field Name"
  - label needs colon and mnemonic
  - label is too verbose, change to "Field name:"
Comment 1 Karsten Becker CLA 2007-05-04 05:32:56 EDT 
Created attachment 65893 [details]
Patch for UI Issues
Comment 2 Martin Aeschlimann CLA 2007-05-07 07:22:02 EDT 
The field name table should only be used to configure field names.
- When an entry is checked, we should show the currently configured field name. Edit should be enabled
- When an entry is unchecked, we should show the original parameter name. Edit should be disabled.
Comment 3 Martin Aeschlimann CLA 2007-05-07 08:01:21 EDT 
The dialog title should be 'Edit Field Name'
Comment 4 Karsten Becker CLA 2007-05-07 08:11:34 EDT 
It is quite difficult to give a satisfying ui feedback for disabled table cells. If the user would like to change the name of some parameters he would have to call rename, even though he could easily change it here. I find it very convenient and I guess Markus too.. (it basically was his propose ;)
Comment 5 Martin Aeschlimann CLA 2007-05-07 08:31:22 EDT 
The table is labeled as 'Select the fields...' and it's strange to also use it to configure parameters here.
I don't think users will realize that sometimes the modify the parameter name and sometimes field names.
The entry doesn't need to be disabled, just not modifiable and the 'Edit...' button disabled. We could also call the button 'Edit Field Name...' to make things clear.

Renaming parameters is better done with other refactorings.
Comment 6 Karsten Becker CLA 2007-05-08 05:07:49 EDT 
Created attachment 66265 [details]
Adopted for current CVS Base
Comment 7 Karsten Becker CLA 2007-05-08 05:08:02 EDT 
Created attachment 66266 [details]
Adopted for current CVS Base
Comment 8 Karsten Becker CLA 2007-05-08 05:09:11 EDT 
Comment on attachment 66265 [details]
Adopted for current CVS Base

dup submission
Comment 9 Martin Aeschlimann CLA 2007-05-10 03:12:28 EDT 
see comment 5.
Comment 10 Karsten Becker CLA 2007-05-10 05:40:37 EDT 
Created attachment 66638 [details]
Disable edit if not marked as field
Comment 11 Martin Aeschlimann CLA 2007-05-10 06:48:34 EDT 
patch is good.
released > 20070510
Comment 12 Benno Baumgartner CLA 2007-05-16 11:39:19 EDT 
verified in I20070516-0010