Community
Participate
Working Groups
I20070427-0010 The 'Open Log' action from the Error Log view should set the caret to the end of the editor. The start of the log file is arbitrary (since it is mostly a continuation...). The end is where interesting stuff happens.
Nice idea. Bugday?
sure, as long as the solution does not require adding heavyweight dependency to the org.eclipse.pde.runtime plug-in. It must remain lightweight so that the plug-in can be dropped in an RCP app.
I'd rather suppose it will induce a dependency to text (if it doesn't have one already, that is), since we'd have to interact with the text editor in which the log file is opened. Please assign to me, I'll create a patch and you can see if you like it or not :-)
The only dependencies the plug-in must have are core.runtime and org.eclipse.ui. This function of opening the file in a default editor is only available in an IDE context and hence the "optional" dependency of the IDE-specific plug-ins.
Created attachment 74827 [details] Patch for bug 184473 Patch makes editor jump to end of log file if log file is opened in internal text editor.
Created attachment 74828 [details] mylyn/context/zip
I had to add an optional dependecy to jface.text, but I made sure we check whether this plug-in is available before enabling the action. Hope this is ok with you...
Brian / Wassim, do you think the added functionality is useful enough for the optional dependency weirdness? Thanks Peter!
We already have optional dependency weirdness, so a little more shouldn't hurt :)
weirdness is a slippery slope.
The patch also seems to add a new dependency on org.eclipse.ui.editors via Import-Package. Brian, I will let you decide if we should put it in or not. However, my feeling is that the caret position does not warrant this big dependency production and we should close as WONTFIX.
Brian, see my previous comment.
This bug is definitely a nice to have. This fix requires nearly doubling the dependencies of the org.eclipse.pde.runtime plug-in along with some messy code (not due to Peter's code, just the APIs available). For this reason, I think this one is best left as WONTFIX. Peter, thanks for the patch. It worked good and I would have done it extremely similar myself.
(In reply to comment #13) > This bug is definitely a nice to have. This fix requires nearly doubling the > dependencies of the org.eclipse.pde.runtime plug-in along with some messy code > (not due to Peter's code, just the APIs available). For this reason, I think > this one is best left as WONTFIX. Agree. > Peter, thanks for the patch. It worked good and I would have done it extremely > similar myself. You're welcome!
