Bug 184449 - [Template Engine] It should be possible to press "Finish" on the first wizard page for templates having default values assigned
Summary: [Template Engine] It should be possible to press "Finish" on the first wizard...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.0 M7   Edit
Assignee: Bala Torati CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-04-27 11:14 EDT by Mikhail Sennikovsky CLA
Modified: 2008-06-20 11:26 EDT (History)
1 user (show)

See Also:

Attachments
Patch with fixes for 184449, 184445 and 184593 (39.61 KB, patch)
2007-05-10 06:55 EDT, Bala Torati CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Sennikovsky CLA 2007-04-27 11:14:28 EDT 
I had to add a "getComposite() != null"
check to the UIWizardPage.isPageComplete() which disables the "Finish" until
all the template pages are visited because I had NPE on project creation when pressing "Finish" on the first wizard page because some TE pages UI controlls were not initialized.

It seems that the UI control does not have to be created unless the page is visited, so it seems we do not need to hold the data necessary for the project creation within the UI control, although I might not understand some TE unctionality details to say this for sure..

Thanks,
Mikhail
Comment 1 Mikhail Sennikovsky CLA 2007-04-27 11:56:06 EDT 
Hi Bala,

I'll target this bug to M7 and assign it to you since we can not keep M7-targetted bugs unassigned.

Thanks,
Mikhail
Comment 2 Bala Torati CLA 2007-05-10 06:55:09 EDT 
Created attachment 66643 [details]
Patch with fixes for 184449, 184445 and 184593

This patch includes fixes for 3 bugs (184449, 184445 and 184593).
Comment 3 Mikhail Sennikovsky CLA 2007-05-10 06:58:10 EDT 
Thanks, Bala!

I'll have a look..

Mikhail
Comment 4 Mikhail Sennikovsky CLA 2007-05-10 12:11:09 EDT 
(In reply to comment #2)
> Created an attachment (id=66643) [details]
> Patch with fixes for 184449, 184445 and 184593
> 
> This patch includes fixes for 3 bugs (184449, 184445 and 184593).
> A fix for this is included in the patch attached with bug 184449.
Thanks Bala,

The patch is applied with small modifications. 
Closing the bug..

Thanks,
Mikhail