Bug 184134 - Warning messages generated by Eclipse 3,.3 need to be fixed.
Summary: Warning messages generated by Eclipse 3,.3 need to be fixed.
Status: CLOSED FIXED
Alias: None
Product: STEM
Classification: Technology
Component: Internal (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: John Thomas CLA
QA Contact: Daniel Ford CLA
URL:
Whiteboard:
Keywords: consistency
Depends on:
Blocks:
 
Reported: 2007-04-25 17:56 EDT by John Thomas CLA
Modified: 2009-10-29 11:35 EDT (History)
1 user (show)

See Also:


Attachments
fixes for wrning messages (6.90 KB, patch)
2007-05-01 18:14 EDT, John Thomas CLA
no flags Details | Diff
fix warning (extra ;) ohf.stem.ui project (6.90 KB, text/plain)
2007-05-02 12:36 EDT, John Thomas CLA
webdaford: iplog+
Details
fix1 (1000 bytes, patch)
2007-05-02 13:06 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff
fix 2 (664 bytes, patch)
2007-05-02 13:07 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff
fix 3 (564 bytes, patch)
2007-05-02 13:08 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff
fix 4 (530 bytes, patch)
2007-05-02 13:09 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff
fix 5 (3.43 KB, patch)
2007-05-02 13:10 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff
fix 6 (637 bytes, patch)
2007-05-02 13:12 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff
fix 7 (536 bytes, patch)
2007-05-02 13:12 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff
fix 8 (626 bytes, patch)
2007-05-02 13:16 EDT, John Thomas CLA
webdaford: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Thomas CLA 2007-04-25 17:56:31 EDT
Eclipse 3.3 has generated 60+ warning messages that were not generated in 3.2.
These need to be resolved.
Comment 1 John Thomas CLA 2007-05-01 17:50:49 EDT
many of the warnings have been fixed.  The majority of the remaining are of the form:

Severity and Description	Path	Resource	Location	Creation Time	Id
Javadoc: 'public' visibility for malformed doc comments hides this 'protected' reference	org.eclipse.ohf.stem.internal.data/src/org/eclipse/ohf/stem/internal/data	RelativePhysicalRelationshipGraphRecord.java	line 82	1178033465441	1440


I have no idea what this is and I suspect that it is something bad generated by EMF.  What to do????
Comment 2 John Thomas CLA 2007-05-01 18:14:33 EDT
Created attachment 65541 [details]
fixes for wrning messages

This is a partial patch of the warning messages
Comment 3 Daniel Ford CLA 2007-05-02 11:55:22 EDT
I couldn't apply the patch.  I guess I'm still figuring out how things work, but things didn't work as usual.  The process of applying a patch prompts for applying it to the workspace or to a single specific project.  It's not always clear which project, but I can usually guess and get it right.  In this case I think the patch contained several different projects, but when I applied it to the workspace I got an error dialog.  Maybe you could submit a patch for a single project and we can try doing this one in small steps.  

Meanwhile, I'll try hunting down the ones you mention.
Comment 4 John Thomas CLA 2007-05-02 12:36:55 EDT
Created attachment 65632 [details]
fix warning (extra ;)   ohf.stem.ui   project
Comment 5 John Thomas CLA 2007-05-02 13:06:13 EDT
Created attachment 65639 [details]
fix1
Comment 6 John Thomas CLA 2007-05-02 13:07:36 EDT
Created attachment 65640 [details]
fix 2
Comment 7 John Thomas CLA 2007-05-02 13:08:49 EDT
Created attachment 65641 [details]
fix 3
Comment 8 John Thomas CLA 2007-05-02 13:09:31 EDT
Created attachment 65642 [details]
fix 4
Comment 9 John Thomas CLA 2007-05-02 13:10:52 EDT
Created attachment 65643 [details]
fix 5
Comment 10 John Thomas CLA 2007-05-02 13:12:00 EDT
Created attachment 65644 [details]
fix 6
Comment 11 John Thomas CLA 2007-05-02 13:12:45 EDT
Created attachment 65645 [details]
fix 7
Comment 12 John Thomas CLA 2007-05-02 13:16:55 EDT
Created attachment 65646 [details]
fix 8

OK that is all for now.

It probably would have been easier for you to have made the original changes instead of making patch file for so many different rojects

However it looks like Eclipse Team support for apply patch allows you to let it figure things out itself and would have handled the multi project patch.  Maybe this was just a mylar bug.
Comment 13 Daniel Ford CLA 2007-05-02 13:55:41 EDT
I was only able to apply #1 and #5, the rest are individual files with no associated project information.  I can't match them to anything specific.  Can you tell me which fix applies to which project?
Comment 14 Daniel Ford CLA 2007-05-02 14:23:42 EDT
fixed them manually.  
There is still a seemingly bogus "extra semicolon" warning through.
Comment 15 Daniel Ford CLA 2007-05-02 14:24:01 EDT
committed
Comment 16 Daniel Ford CLA 2009-10-29 10:41:14 EDT
Comment on attachment 65646 [details]
fix 8

flagged attachment for iplog
Comment 17 Daniel Ford CLA 2009-10-29 10:42:57 EDT
Comment on attachment 65646 [details]
fix 8

flagged attachment for iplog
Comment 18 Daniel Ford CLA 2009-10-29 10:43:18 EDT
Comment on attachment 65639 [details]
fix1  

flagged attachment for iplog
Comment 19 Daniel Ford CLA 2009-10-29 10:45:17 EDT
the entire bug is flagged for iplog as all attachments should be flagged
Comment 20 Daniel Ford CLA 2009-10-29 11:33:44 EDT
removed iplog flag for entire bug
Comment 21 Daniel Ford CLA 2009-10-29 11:34:06 EDT
Comment on attachment 65632 [details]
fix warning (extra ;)   ohf.stem.ui   project

flagged for iplog
Comment 22 Daniel Ford CLA 2009-10-29 11:34:20 EDT
Comment on attachment 65640 [details]
fix 2

flagged for iplog
Comment 23 Daniel Ford CLA 2009-10-29 11:34:32 EDT
Comment on attachment 65641 [details]
fix 3

flagged for iplog
Comment 24 Daniel Ford CLA 2009-10-29 11:34:44 EDT
Comment on attachment 65642 [details]
fix 4

flagged for iplog
Comment 25 Daniel Ford CLA 2009-10-29 11:34:56 EDT
Comment on attachment 65643 [details]
fix 5

flagged for iplog
Comment 26 Daniel Ford CLA 2009-10-29 11:35:07 EDT
Comment on attachment 65644 [details]
fix 6

flagged for iplog
Comment 27 Daniel Ford CLA 2009-10-29 11:35:18 EDT
Comment on attachment 65645 [details]
fix 7

flagged for iplog