Community
Participate
Working Groups
Build ID: I20070323-1616 Steps To Reproduce: 1. Open the C/C++ Developer Guide 2. Look for into on Breakpoint Actions None is present. More information: - added Breakpoint action pages for: -- ref/pref panel -- task/adding breakpt action -- task/attaching and removing brkpt actions - revised task and ref TOCs
Created attachment 64443 [details] Pages and images for brkpt action pages
Hi Frank. I'm starting to go through your patches. But I'm having trouble applying them. Did you use Eclipse's create patch to create them?
Yes I did, but in speaking with Ken on this yesterday looks like I misunderstood the meaning of the patch flag. I assumed it simply marked it as a patch so that the commiters could search for patches. Now I know they are for indicating patch files only. Duh! Anyway, most of the 'patches' I uploaded and marked as such are really zip files with the patch file and updated images inside a folder. Sorry for the confusion on those. Now that I know better I won't make that mistake again.
Actually using the patch flag is fine. It's what I'm doing my search on to find the patches so they are easier to find that way. Downloading them they get recognized as zip files so I have no problem with that. The problem I'm having is that the Apply Patch is getting confused by the directory structure and for some reason, Ignore leading path name segments isn't letting me change it. Also, I'm finding that ^M's are getting inserted into your file. Are you creating the patch on Windows?
Oh, wait, I think I see. The patch thinks the project is org.eclipse.cdt-doc. That's not a project. The project should be org.eclipse.cdt.doc.user.
Well, pretty much all I'm doing is selecting the files that have changed and choosing team > create patch. I do note the the cvs download on my work machine has the doc plugins as separate projects, not combined under a single project. I'll fix that asap. Some of the early writing was done on a Mac, but I've since just started using Parallels at home to avoid any issues there and to get the screenshots correct.
If it makes it easier, once you have the user.doc as it's own project, I'd accept a big patch that has all your updates to the docs. It'd be easier for me to apply too :). Thanks!
Created attachment 67567 [details] Real patch file with images included Ok, downloaded org.eclipse.cdt.doc.user as standalone project and ran create patch for project and included binaries with it. Includes patches for: - modules view (#184742) - breakpoint actions (#183385) - before you begin move (#100702) - run config update to remove bgcolor (#183537) These were what I had done on my home machine, will get ones off work machine asap.
Unfortunately, the images didn't work out. This could be a line ending issue between Mac and Windows (I'm on Windows). I got no warnings but I can't preview the images in the Image Previewer like I can the other png files.
Will separate patch and images files and resubmit tonight.
Created attachment 67741 [details] Zip of patch file and separate image files
That did it, thanks Frank! Patch applied. I'll mark the bug reports you mentioned as duplicates of this one.
*** Bug 184742 has been marked as a duplicate of this bug. ***
*** Bug 100702 has been marked as a duplicate of this bug. ***
assigning
done