Bug 183161 - [api] SystemFilterPoolManager should be internal
Summary: [api] SystemFilterPoolManager should be internal
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: David Dykstal CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 170932
  Show dependency tree
 
Reported: 2007-04-19 07:19 EDT by Martin Oberhuber CLA
Modified: 2008-08-13 13:18 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-04-19 07:19:08 EDT 
SystemFilterPoolManager seems to be an implementation class only. All client access happens through ISystemFilterPoolManager, and it is not intended to be extended.

The instance creation method
   SystemFilterPoolManager.createSystemFilterPoolManager()
should be moved somewhere else, I would propose into RSECorePlugin or into IRSEPersistenceManager.

Javadoc of SystemFilterPoolManager should be cleaned up from references like "every filter maps to a folder" -- with the new persistence scheme this is not necessarily true any more. Also, Javadoc should say "This class is not intended to be subclassed by clients".
Comment 1 David Dykstal CLA 2007-04-19 09:31:26 EDT 
Agreed.
Comment 2 David Dykstal CLA 2007-05-07 14:55:59 EDT 
In preparation for moving the class to org.eclipse.rse.internal.core.filters we will remove the unused static public factory method that was commented as private and change the class comments to remove all persistence policy language.

I recommend that we leave the static factory method as is for now. Neither of the suggested places appear to be a good place for it. Moving the class to internal makes finding a home for this a bit less of a problem. At some point in the future the using class SubSystemConfiguration should be moved into the core plugin as well so the use of an internal class does not pose a problem at this time.
Comment 3 David Dykstal CLA 2007-05-07 15:08:40 EDT 
[api][refactor] Move SystemFilterPoolManager to org.eclipse.rse.internal.core.filters.
Comment 4 Martin Oberhuber CLA 2008-08-13 13:18:27 EDT 
[target cleanup] 2.0 M7 was the original target milestone for this bug