Bug 18311 - api: ISourceReference::getSource can return undocumented result
Summary: api: ISourceReference::getSource can return undocumented result
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Jerome Lanneluc CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 130161 156688 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-05-30 10:11 EDT by Adam Kiezun CLA
Modified: 2007-08-03 10:21 EDT (History)
2 users (show)

See Also:

Attachments
Proposed fix (1.12 KB, patch)
2007-07-03 11:06 EDT, Jerome Lanneluc CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-05-30 10:11:10 EDT 
for binary members, ISourceReference::getSource returns a special value 
sometimes SourceMapper.fgUnknownRange

however, this fact is not documented anywhere and the value itself is not api.
the only woraround i see now is to hard-code the range {-1, 0}
Comment 1 Philipe Mulet CLA 2002-05-31 05:30:44 EDT 
Please fix the spec
Comment 2 Olivier Thomann CLA 2002-05-31 10:33:26 EDT 
I think the good fix is to return null for the getSourceRange() of BinaryMember.
Comment 3 Olivier Thomann CLA 2002-05-31 11:46:03 EDT 
Defer post 2.0.
Comment 4 Jerome Lanneluc CLA 2007-07-03 10:58:58 EDT 
reopening
Comment 5 Jerome Lanneluc CLA 2007-07-03 11:00:12 EDT 
*** Bug 130161 has been marked as a duplicate of this bug. ***
Comment 6 Jerome Lanneluc CLA 2007-07-03 11:06:35 EDT 
Created attachment 72960 [details]
Proposed fix
Comment 7 Jerome Lanneluc CLA 2007-07-03 11:07:46 EDT 
Fix released for 3.4M1 in HEAD.
Comment 8 Frederic Fusier CLA 2007-08-03 10:20:48 EDT 
Verified for 3.4M1 using build I20070802-0800.
Comment 9 Frederic Fusier CLA 2007-08-03 10:21:47 EDT 
*** Bug 156688 has been marked as a duplicate of this bug. ***