Community
Participate
Working Groups
This patch try to remove all the display bugs that I have see, so I have make printscreens of it and try to solve these bugs 1 by 1. Just one bug is not fixed see patch-printscreen.png. Patch: is used in more than 40 Fedora extras specfiles. If somebody with knowledge of the SpecfileParser code can take a look, he should certainly easily fix him as me. Have remove (commented) the License acronym warning but I'm not sure if that's a good thing, IMHO not acronym License is too widely used to show this warning. Cheers, 2007-04-14 Alphonse Van Assche <alcapcom@gmail.com> * src/org/eclipse/linuxtools/rpm/ui/editor/PackageWordDetector.java (isWordPart): Detect packages contain '_' char. * src/org/eclipse/linuxtools/rpm/ui/editor/parser/SpecfileParser.java (parseLine): Fix tags parsing. (parseSimpleDefinition): Don't show warning about acronym error. * src/org/eclipse/linuxtools/rpm/ui/editor/SpecfileScanner.java (sections): Add %clean and %check section. * src/org/eclipse/linuxtools/rpm/ui/editor/SpecfilePackagesScanner.java (PACKAGES_TAGS): Add Requires(hint) (SpecfilePackagesScanner): Add comment support.
Created attachment 63719 [details] some-display-fixes-on527
Created attachment 63720 [details] clean-check-section.png
Created attachment 63721 [details] comment-not reconize-in-packages-context.png
Created attachment 63722 [details] Name-not correcly-parsed.png
Created attachment 63723 [details] patch-printscreen.png
Created attachment 63724 [details] requires(hint).png
Created attachment 63725 [details] underscore-in-package.png
Created attachment 63748 [details] package names as sub-names of other package names I've got another display issue: partial RPM package names within others (ex. 'at' in the middle of 'java-gcj-compat'). Here's a screenshot.
Created attachment 63817 [details] Fix: package names as sub-names of other package names With this patch we check packages in a more close way and fix that kind of bug. I'm not sure, but that can slow down the scanning. Have a nice weekend, Alphonse * src/org/eclipse/linuxtools/rpm/ui/editor/PackageWordDetector.java (isWordStart): Add support for packages begining with ' ' | ',' | '\t' | ':' char * src/org/eclipse/linuxtools/rpm/ui/editor/SpecfilePackagesScanner.java (SpecfilePackagesScanner): Detect packages that begin with ' ' | ',' | '\t' | ':' char
It would be great if we could have tests accompanying bug fixes like this so we can ensure that the fix actually does fix the issue. Also, that will hopefully prevent the same issues from happening again :). I see what you're saying about the Patch with no number issue: Exception in thread "org.eclipse.jface.text.reconciler.MonoReconciler" java.lang.NumberFormatException: For input string: "" Can you file a separate bug about that one? Thanks. Otherwise, all of the images you submitted seem to have been fixed! Thanks for the patch. Committed as rev. 612.
(In reply to comment #10) > It would be great if we could have tests accompanying bug fixes like this so we > can ensure that the fix actually does fix the issue. Also, that will hopefully > prevent the same issues from happening again :). :) > > I see what you're saying about the Patch with no number issue: > > Exception in thread "org.eclipse.jface.text.reconciler.MonoReconciler" > java.lang.NumberFormatException: For input string: "" > > Can you file a separate bug about that one? Thanks. Ok, I do that now. > Thanks for the patch. Committed as rev. 612. > Great!
Comment on attachment 63719 [details] some-display-fixes-on527 Setting iplog flag.
Comment on attachment 63817 [details] Fix: package names as sub-names of other package names Setting iplog flag.
