Community
Participate
Working Groups
While investigating bug 181994, we noticed that the PDE source lookup director creates a source container each time it looks up source. If this approach is to be used, it would be best to "dispose()" of each container once done with it. However, it would likely be even better to cache/re-use source containers per source lookup director instance. It would create less gargbage, and should be event faster (than creating them on demand for each request).
This could be a good bug to get some new feet wet with :)
ok, sweet. first one to get the patch wins the race. Your picture will go on our famous PDE committer/contributor webpage. http://www.eclipse.org/pde/pde-ui/committers/committers.php gogogogogo
Created attachment 77924 [details] patch Adds a cache of source containers to the PDE source lookup director. The source lookup query retrieves source containers from the director rather than building them on each request. Containers are disposed when the director is disposed (when the launch is removed). Containers are added to the cache lazily - the first time a container is required for a location/bundle. Makes moving between stack frames (source lookup) in different bundles more snappy.
just had to beat me to it :) not axesome
That was quick! Debug doesn't mess around.
That's what I'm talking about, bug reporters who actually solve the bug they report ;)
Darin, looks very good, not to mention the quick turn around. I like the custom key object :) Patch applied as-is to HEAD. Will be available in 3.4M2.
Admitedly - I had an unfair advantage here since it was an implementation of an interface that debug defines. However, it's good practice to eat your own dog food. The PDE source lookup director is interesting in that it performs a dynamic source lookup based on bundles, rather than searching along a path for source (i.e. like a typical classpath).
Now we need a picture of Darin featuring a "leafy background" to put him on PDE's hall of fame webpage.
(In reply to comment #9) > Now we need a picture of Darin featuring a "leafy background" to put him on > PDE's hall of fame webpage. Actually, if you look at his sametime picture, you will notice that it promotes the PDE trademarked "leafy background". He was clearly born ready.
I am not sure this bug challenged Darin to step out of his comfort zone. It's an optimization of a source lookup director that is based on the debug framework. Can we have him write a form-based editor or something? :)
