Bug 182167 - Warning not issued when non-instantiable class is bypassed in sampe JSPs
Summary: Warning not issued when non-instantiable class is bypassed in sampe JSPs
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 RC1   Edit
Assignee: Andrew Mak CLA
QA Contact: Chris Brealey CLA
URL:
Whiteboard: PMC_approved
Keywords: contributed, PII
Depends on:
Blocks:
 
Reported: 2007-04-12 12:39 EDT by Andrew Mak CLA
Modified: 2008-06-04 11:21 EDT (History)
3 users (show)

See Also:
david_williams: pmc_approved+
kathy: pmc_approved? (raghunathan.srinivasan)
kathy: pmc_approved? (naci.dai)
kathy: pmc_approved? (deboer)
kathy: pmc_approved? (neil.hauge)
kathy: pmc_approved? (kaloyan)

Attachments
patch (9.59 KB, patch)
2008-05-05 12:54 EDT, Andrew Mak CLA 		makandre: review?
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Mak CLA 2007-04-12 12:39:36 EDT 
In bug 180952, a fix was made to the sample JSP generation to bypass non-instantiable classes, since they result in compile errors when we construct them via the useBean action.  However, we did not add warning messages when classes are bypassed because this requires translate which is outside the scope of the service release.

We will use this bug to add back warning messages in a later release.
Comment 1 Kathy Chan CLA 2007-09-28 16:38:38 EDT 
Over to you, Gil.
Comment 2 Kathy Chan CLA 2008-05-02 15:51:33 EDT 
Andrew, please add the message to this release.
Comment 3 Andrew Mak CLA 2008-05-05 12:54:37 EDT 
Created attachment 98672 [details]
patch

The proposed warning message is:

The input type {0} is a non-instantiable type and will be omitted from the sample JSP.  Continue with sample JSP generation?
Comment 4 Andrew Mak CLA 2008-05-05 13:17:15 EDT 
When the sample JSP generator encounters an input type that cannot be instantiated via the jsp:useBean tag, the method using that type is simply omitted from the generated sample JSP.  There is no warning when the wizard is running nor does the generate pages indicate that some methods are omitted.  This is not very user friendly.

The fix involves setting the status with an appropriate warning message when non-instantiable classes are encountered.  Previously an OK status is returned from this block of code.  There are also a couple changes made so that clicking cancel from the warning dialog will terminate the wizard flow.

I've tested this using the test files from bug 180952.

Kathy, please review this patch.
Comment 5 Kathy Chan CLA 2008-05-07 14:37:31 EDT 
Patch reviewed.  Thanks Andrew!

PMC, please approve for WTP 3.0 RC1.
Comment 6 David Williams CLA 2008-05-09 00:09:16 EDT 
I'll approve this one, and appreciate the efforts to improve usability, but ... it's pretty late to be making changes that involve PII, so, please use care, Kathy. (Or, explain better why it's so bad or such a high priority).
Comment 7 Kathy Chan CLA 2008-05-09 10:24:25 EDT 
Thanks for approving!  Yes, I realize it's a bit late to make PII changes.  This one missed the sweep when we check for defects that requires PII changes.  Since this one would improve usability and let the user know what's going on, I tried to get this in for WTP 3.0 rather than waiting for the next release.

I've committed the patch and released to HEAD as v200805091419.
Comment 8 Andrew Mak CLA 2008-06-04 11:21:13 EDT 
Verified on wtp-S-3.0RC3-20080529235434.