Community
Participate
Working Groups
I20070327-0800 The config.ini generated by PDE on startup of a launch configuration marks fragments to be started. This causes an exception to be generated at runtime when the framework is trying to start the bundle which unnecessarily fills the log. Could you please not mark fragments for start. Thx.
Is this for OSGi launch configs or Eclipse application launch configs? Is update.configurator involved here or no?
This problem shows up when I'm using an osgi launch configuration, it probably happens the same way with an eclipse one. Update configurator does its stuffs properly Tom verified the code.
That's what I thought. It is not a problem in Eclipse app launch configs where we generate the config.ini for you. As for the OSGi launch config, you are in total control. So fragments are being started, because that's how you specified it on the Bundles tab in the launch configs. Now if it does not make sense to have the user control the fragment status, then PDE could make the autostart setting for each fragment read-only and set to false.
+1 for making fragments start-status read-only and set to false on the OSGi launcher bundles tab.
Is there ever a scenario a user would want to start a fragment using the config.ini? If so, I would prefer to have the fragment's start status set to false, but be editable just in case the user wants to manually override it. If there is never a case a user would want to do that, we can make it read-only to prevent confusion.
(In reply to comment #5) > Is there ever a scenario a user would want to start a fragment using the > config.ini? If so, I would prefer to have the fragment's start status set to > false, but be editable just in case the user wants to manually override it. If > there is never a case a user would want to do that, we can make it read-only to > prevent confusion. > There is no reason to start a fragment. Starting a fragment in the config.ini will never work because OSGi states that starting a fragment throws a BundleException. This is why I think fragments start status should not be editable and should be set to false.
I'll look at fixing this one. Should the user still be able to set the start level?
Created attachment 85590 [details] Patch Patch changes OSGiBundlesBlock to always set the text of the autostart column to false if the model is a fragment. The column editor is removed so the user cannot change it.
Brian, please review. If it turns out the start level of fragments should be set to an uneditable value, it will be easy for me to update the patch.
Created attachment 86014 [details] org.eclipse.pde.ui.patch I updated the patch to not show an editable value for start level for fragments too.
Created attachment 86015 [details] mylyn/context/zip
Thanks again Curtis!
Verified on I20080204-0800. I like way this behaves. Good job guys!
