Bug 181102 - Test failures due to change in SpecfileParser#parseSection
Summary: Test failures due to change in SpecfileParser#parseSection
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: RPM (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: RPM Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-04-04 21:07 EDT by Andrew Overholt CLA
Modified: 2009-01-23 10:20 EST (History)
1 user (show)

See Also:

Attachments
Patch to fix the tests (1.64 KB, patch)
2007-04-05 12:00 EDT, Igor Foox CLA 		overholt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Overholt CLA 2007-04-04 21:07:29 EDT 
With a commit to make top-level packages show up in the outline view, the testGetComplexSectionName*
tests
in HeaderRecognitionTests started failing.  Igor, can you take a look at this when
you
get a chance?  It can be duplicated just by running the test suite.
Comment 1 Igor Foox CLA 2007-04-04 22:34:36 EDT 
I'll take a look.
Comment 2 Igor Foox CLA 2007-04-05 12:00:13 EDT 
Created attachment 63056 [details]
Patch to fix the tests

The problem was that we didn't update the tests to reflect new code. Here's a pretty simple patch to fix these tests.
Comment 3 Andrew Overholt CLA 2007-04-05 12:17:53 EDT 
 (In reply to comment #2)
> The problem was that we didn't update the tests to reflect new code. Here's a
> pretty simple patch to fix these tests.

Sweet, thanks, Igor!  Sorry for being a moron and not seeing the obvious fix.  All the tests now pass.

Patch applied as revision 507.

2007-04-05  Andrew Overholt  <overholt@redhat.com>

	* src/org/eclipse/linuxtools/rpm/ui/editor/tests/HeaderRecognitionTest.java (newFile): Remove unnecessary specfile instantiation.
	(setUp): Instantiate specfile object.
	(testGetComplexSectionName3): Update test to use getPackageName() instead of getName().
	(testGetComplexSectionName4): Likewise.
	(testGetComplexSectionName5): Likewise.
Comment 4 Andrew Overholt CLA 2009-01-23 10:20:21 EST 
Comment on attachment 63056 [details]
Patch to fix the tests

Setting iplog flag.