Bug 180683 - codeSelect does not work in unicode names like \u0042
Summary: codeSelect does not work in unicode names like \u0042
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-03 07:01 EDT by Markus Keller CLA
Modified: 2007-04-27 09:48 EDT (History)
0 users

See Also:

Attachments
Proposed fix (3.67 KB, patch)
2007-04-06 07:00 EDT, David Audel CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-04-03 07:01:22 EDT 
HEAD

ICodeAssist.codeSelect(int, int) does not work on unicode names like \u0042, e.g. set caret to between 00 and 42 in the class declaration name and press Ctrl+Shift+G:

  public class \u0042 {

        public static \u0042 newInstance() {
                return new \u0042();
        }

        public \u0042() {
        }
  }
Comment 1 David Audel CLA 2007-04-06 07:00:51 EDT 
Created attachment 63162 [details]
Proposed fix
Comment 2 David Audel CLA 2007-04-06 07:06:48 EDT 
Released for 3.3M7

Tests added
  ResolveTests#testUnicode2()->testUnicode3()

SelectionEngine#checkSelection() didn't correctly find the end of identifier if the caret is inside an unicode.
Comment 3 Olivier Thomann CLA 2007-04-27 09:48:51 EDT 
Verified for 3.3M7 using I20070427-0010