Bug 180602 - [api] Remove Communications Daemon and associated classes
Summary: [api] Remove Communications Daemon and associated classes
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Kushal Munir CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-04-02 20:58 EDT by Kushal Munir CLA
Modified: 2008-08-13 13:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kushal Munir CLA 2007-04-02 20:58:53 EDT 
Get rid of the system communications daemon which is a daemon provided by RSE that listens to incoming requests. This was added for tools which might want to connect from the server to the client (upon, say, starting the tool).

However, we can not see a clear need for it and the protocol to interact with the daemon is not well defined, so we will remove the following classes from org.eclipse.rse.core.comm package:
 - ISystemCommunicationsDaemonHandler
 - ISystemCommunicationsDaemonListener
 - SystemCommunicationsDaemon
 - SystemCommunicationsDaemonEvent

We will also remove the Communications preference page and all associated labels, tooltips, F1 help and error messages.
Comment 1 Kushal Munir CLA 2007-04-02 21:21:54 EDT 
Also removed SystemStartCommunicationsDaemonAction which was an action available from the Remote Systems view menu to start or stop the daemon.

Daemon and all related classes are now removed.
Comment 2 Martin Oberhuber CLA 2007-04-05 06:44:23 EDT 
Found this in rse.ui/HelpContexts.xml, please remove and check for other traces of the communications daemon

<!-- RSE Communications daemon action -->
<context id="dmna0000">
<description>This action starts and stops the local Remote System Explorer (RSE) communications daemon.  This daemon is not directly used by individual RSE connections.  Instead it allows local Workbench functions to accept incoming socket requests from remote systems.  You can set the daemon to automatically start and configure the port used by the daemon in the Workbench preferences under Remote Systems->Communications.</description>
Comment 3 Martin Oberhuber CLA 2007-04-05 08:35:33 EDT 
Also found this in systemMessages.xml line 1308:

<Message ID="2201" Indicator="E">
<LevelOne>The RSE communications daemon could not be started.</LevelOne>
</Message>

corresponding to this in ISystemMessages.java, nowhere referenced:
public static final String MSG_COMM_DAEMON_NOTSTARTED	= "RSEC2201"; 

I think these are obsolete, so I would vote for removing them.
I'd rather not see them in Open Source since the "Communications Daemon" was always so easy to confuse with the "Dstore daemon".
Comment 4 Kushal Munir CLA 2007-04-05 12:47:09 EDT 
Got rid of the associated message and F1 help.
Comment 5 Martin Oberhuber CLA 2008-08-13 13:17:33 EDT 
[target cleanup] 2.0 M6 was the original target milestone for this bug