Bug 179910 - [api] Remove unneccesary download and upload methods from IRemoteFileSubSystem
Summary: [api] Remove unneccesary download and upload methods from IRemoteFileSubSystem
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Kushal Munir CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-03-29 01:12 EDT by Kushal Munir CLA
Modified: 2008-08-13 13:17 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kushal Munir CLA 2007-03-29 01:12:09 EDT
IRemoteFileSubSystem has a number of overloaded methods for download and upload. Most of these are unnecessary and make the interface complicated.

All download methods will be consolidated to one method:
 - public void download(IRemoteFile source, String destination, String encoding, IProgressMonitor monitor) throws RemoteFileSecurityException, RemoteFileIOException

All upload methods will be consolidated to two methods:
 - public void upload(String source, IRemoteFile destination, String encoding, IProgressMonitor monitor) throws RemoteFileSecurityException, RemoteFileIOException

 - public void upload(String source, String srcEncoding, String remotePath, String rmtEncoding,  IProgressMonitor monitor) throws RemoteFileSecurityException, RemoteFileIOException

The first upload method is for cases where the destination IRemoteFile exists and we can check for authority to write. The second is the case where the destination will be created if needed, i.e. the destination path is specified as a string.
Comment 1 Kushal Munir CLA 2007-03-29 01:16:30 EDT
Also cleaned up the subclass RemoteFileSubSystem so that now there are no implementations of download and upload in the class. The FileServiceSubSystem implements the download and upload methods, as before, i.e. the overloaded methods that RemoteFileSubSystem implemented were redundant and all ended up calling the download and upload methods that were implemented in FileServiceSubSystem. 
Comment 2 Martin Oberhuber CLA 2007-03-29 05:36:50 EDT
The changes broke the build for org.eclipse.rse.importexport

Please re-import the rse-committer.psf team project set from the www-tm-development project and fix the build errors.
Comment 3 Kushal Munir CLA 2007-03-29 06:35:20 EDT
The projects were not in my working set. Fixed problems in the project.
Comment 4 Martin Oberhuber CLA 2008-08-13 13:17:33 EDT
[target cleanup] 2.0 M6 was the original target milestone for this bug