Bug 179192 - BIDI3.3:HCG_GMF: Wrong direction for PathMap in rtl eclipse
Summary: BIDI3.3:HCG_GMF: Wrong direction for PathMap in rtl eclipse
Status: CLOSED FIXED
Alias: None
Product: GMF-Tooling (ARCHIVED)
Classification: Modeling
Component: Core (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 2.0   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-03-25 10:14 EDT by Moshe WAJNBERG CLA
Modified: 2010-07-19 12:18 EDT (History)
8 users (show)

See Also:


Attachments
Proposed patch (3.69 KB, patch)
2007-04-09 12:24 EDT, Christian Damus CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Moshe WAJNBERG CLA 2007-03-25 10:14:54 EDT
Build ID:  I20070222-0951

Steps To Reproduce:
Environment:
-----------------
Windows XP with ability to type BiDi chars:
1. Go to the control panel's "Regional and Language Options" and on the Languages Tab press Details
2. Add Hebrew / Arabic input languages by pressing Add button and selecting the appropriate languages (you might required to use Win OS CD).
3. Reboot the PC


Steps to reproduce the defect:
--------------------------------------
Please notice that this is a BiDi specific defect and it can be reproduced only when BiDi data is used. Please use BiDI characters instead of capital Latin letters in the data samples below.

1.Create the following directories: C:/ABC/DEF
2.In Windows->Preferences=PathMap create the new Path Variable ABC pointing to the previous directory
....

Expected results:
----------------------
The display should be:(From Right to Left) : 
ABC - FED/CBA/:C
 
Actual results:
------------------
The display is: ABC - C:/ABC/EFG

In mirrored (dir -rtl) mode RTL direction is set in all widgets. However, in some of them it must be set to LTR. To this group of widgets belong all widgets holding file path, file names, and such text patterns.

More information:
Comment 1 Moshe WAJNBERG CLA 2007-03-26 05:54:12 EDT
Sorry for the confusion.

Expected results:
----------------------
The display should be:(From Left To Right) : 
c:\CBA\FED - CBA

Actual results:
------------------
The display is: FED/CBA/:C - CBA (From Left To Right)
Comment 2 Anthony Hunter CLA 2007-04-09 11:20:37 EDT
IBM lists this as a serious defect, not sure why.
Comment 3 Christian Damus CLA 2007-04-09 12:24:14 EDT
Created attachment 63269 [details]
Proposed patch

Attached a patch that:
  - updates the list in the preference page to use the TextProcessor
  - updates the diaglog for editing/creating path variables to force
    left-to-right orientation in the location field

Note that this patch distinguishes between path variables that reference file locations and those that reference URIs.  In the latter case, the TextProcessor is used with additional URI-specific separators (!, #, @, ?).

I tested these changes with -nl ar on RedHat Linux, using a folder name containing Arabic characters.
Comment 4 Anthony Hunter CLA 2007-04-12 10:45:33 EDT
Cherie, can you review and commit this patch?
Comment 5 Cherie Revells CLA 2007-04-17 14:00:14 EDT
I contributed Christian's patch the other day (just forgot to resolve this).
[179192] gmf_head crevells 070412 BIDI3.3:HCG_GMF: Wrong direction for PathMap in rtl eclipse
Contributed by: Christian Damus
Comment 6 Moshe WAJNBERG CLA 2007-04-18 05:51:06 EDT
Could you please tell me on which build this defect is solved?

Thanks
Comment 7 Cherie Revells CLA 2007-04-18 08:29:54 EDT
The fix was committed on April 12th, so it should be in the first GMF build after that.
Comment 8 Moshe WAJNBERG CLA 2007-04-22 07:53:31 EDT
Verified in the 20/04 build
Comment 9 Richard Gronback CLA 2008-08-13 13:11:45 EDT
[target cleanup] 2.0 M7 was the original target milestone for this bug
Comment 10 Eclipse Webmaster CLA 2010-07-19 12:18:01 EDT
[GMF Restructure] Bug 319140 : product GMF and component
UI was the original product and component for this bug