Bug 179042 - [DOM] Implementation of IBinding.getModifiers() should return Modifier.NONE when no modifiers are available
Summary: [DOM] Implementation of IBinding.getModifiers() should return Modifier.NONE w...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-23 11:25 EDT by Olivier Thomann CLA
Modified: 2007-04-27 08:31 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2007-03-23 11:25:57 EDT 
Usign 3.3M6, some implementation of this method returns -1.
This is not specified. Modifier.NONE should be returned.
Comment 1 Olivier Thomann CLA 2007-03-23 11:26:19 EDT 
Martin,

Do you agree with this?
Comment 2 Martin Aeschlimann CLA 2007-03-26 04:22:48 EDT 
Oh, yes, -1 is unexpected.
Comment 3 Olivier Thomann CLA 2007-03-26 13:27:56 EDT 
Released for 3.3M7.
Updated regression tests with some check on the getModifiers() call.
Comment 4 Maxime Daniel CLA 2007-04-27 08:31:33 EDT 
According to getModifiers doc, it returns the 'bit-wise or of Modifier constants', which has no chance to evaluate to -1 (-1 is 0xFFFFFFFF, while Modifier constants are all in the 0x0000 to 0xFFFF range).
Checking the source code...
Verified for 3.3 M7 using source code v_751.