Bug 178925 - Provide overrideable method in DiagramEditorWithFlyOutPalette to create custom IActivityManagerListener
Summary: Provide overrideable method in DiagramEditorWithFlyOutPalette to create custo...
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0.2   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.0   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-03-22 20:03 EDT by Christian Vogt CLA
Modified: 2010-07-19 12:30 EDT (History)
0 users

See Also:

Attachments
patch for DiagramEditorWithFlyOutPalette (1.94 KB, patch)
2007-03-22 20:05 EDT, Christian Vogt CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Vogt CLA 2007-03-22 20:03:58 EDT 
The DiagramEditorWithFlyOutPalette creates an IActivityManagerListener in the startListening method. I'd like to propose that the creation of the listener be made extensible to subclasses through an overrideable method. Existing behaviour would remain unchanged.
Comment 1 Christian Vogt CLA 2007-03-22 20:05:32 EDT 
Created attachment 61772 [details]
patch for DiagramEditorWithFlyOutPalette
Comment 2 Anthony Hunter CLA 2007-03-23 07:58:23 EDT 
Hi Cherie. Please do a second review the patch, looks fine to go into 3.3 M6.
Comment 3 Cherie Revells CLA 2007-03-26 11:42:45 EDT 
Looks fine to me.
Comment 4 Cherie Revells CLA 2007-03-26 13:34:30 EDT 
I committed Christian's fix.  
[178925] gmf_head crevells 070326 Provide overrideable method in DiagramEditorWithFlyOutPalette to create custom IActivityManagerListener
Contributed by: Christian Vogt
Comment 5 Richard Gronback CLA 2008-08-13 13:07:36 EDT 
[target cleanup] 1.0 M6 was the original target milestone for this bug
Comment 6 Eclipse Webmaster CLA 2010-07-19 12:30:15 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug