Bug 178566 - [api] AbstractSystemViewAdapter should not implement ISystemPropertyConstants
Summary: [api] AbstractSystemViewAdapter should not implement ISystemPropertyConstants
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Uwe Stieber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 180562
  Show dependency tree
 
Reported: 2007-03-21 11:02 EDT by Martin Oberhuber CLA
Modified: 2008-08-13 13:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-03-21 11:02:30 EDT 
AbstractSystemViewAdapter implements ISystemPropertyConstants for the soul purpose of bringing these constants into its namespace.

We agreed in a committer meeting that this is really a mis-use of the "implements" relation, and constants should be used by directly qualifying them with the interface they are declared in.

Therefore, AbstractSystemViewAdapter should not implement ISystemPropertyConstants.
Comment 1 Martin Oberhuber CLA 2007-03-21 11:03:55 EDT 
Fixed. 
Migration guide:

Classes which derive from AbstractSystemViewAdapter and find compile errors on constants such as P_COMMAND, P_COMMENT need to prefix these constants with the ISystemPropertyConstants interface, i.e.

ISystemPropertyConstants.P_COMMAND
ISystemPropertyConstants.P_COMMENT
Comment 2 Martin Oberhuber CLA 2007-03-21 11:05:14 EDT 
Commited on 19-Mar-2007 for 2.0M6, comment was
"[178020] [178021] [178023] IActionFilter related API changes"
Comment 3 Martin Oberhuber CLA 2008-08-13 13:17:46 EDT 
[target cleanup] 2.0 M6 was the original target milestone for this bug