Bug 178231 - [open type] OpenAction and Open Type should not fully create all editors
Summary: [open type] OpenAction and Open Type should not fully create all editors
Status: ASSIGNED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P5 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: performance
: 330599 (view as bug list)
Depends on: 272884 183602 296477 389108 389478 389901
Blocks:
  Show dependency tree
 
Reported: 2007-03-20 07:20 EDT by Dani Megert CLA
Modified: 2022-12-07 12:46 EST (History)
4 users (show)

See Also:


Attachments
Proof of concept (5.01 KB, patch)
2012-10-17 09:21 EDT, Dani Megert CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-03-20 07:20:01 EDT
I20070320-0010.

Select several files in the Open Type dialog and then press 'Enter'.
==> each editor is fully created. This bad for performance. Only the first or the last editor should be fully created. All others should be opened as part reference like when restarting Eclipse.

This needs new API from Platform UI. I suggest to listen for the corresponding bug in Platform UI (bug 178229).
Comment 1 Martin Aeschlimann CLA 2007-03-20 13:01:29 EDT
Open File... seems to do better here
Comment 2 Markus Keller CLA 2007-03-21 05:12:51 EDT
Same problem occurs when opening multiple files elsewhere (e.g. in Package Explorer).
Comment 3 Markus Keller CLA 2009-03-08 06:57:25 EDT
See API from bug 183602.
Comment 4 Dani Megert CLA 2009-03-24 11:48:50 EDT
Fixed in HEAD.
Available in builds >= N20090324-2000.
Comment 5 Dani Megert CLA 2009-05-11 10:56:08 EDT
We had to back out this change. See bug 275668 for details.
Comment 6 Dani Megert CLA 2009-11-26 03:49:21 EST
Open Type also reveals the element. We would need to have another API that allows to pass in a selection or we create a special editor input that also stores the selection to apply when opening the editor.
Comment 7 Dani Megert CLA 2010-11-19 02:20:31 EST
*** Bug 330599 has been marked as a duplicate of this bug. ***
Comment 8 Dani Megert CLA 2012-09-13 04:44:03 EDT
(In reply to comment #6)
> Open Type also reveals the element. We would need to have another API that
> allows to pass in a selection or we create a special editor input that also
> stores the selection to apply when opening the editor.

Filed bug 389478 to track that.
Comment 9 Dani Megert CLA 2012-10-17 09:21:35 EDT
Created attachment 222470 [details]
Proof of concept

This almost works but has revealing issues due to bug 375576 and/or bug 296477.
Comment 10 Eclipse Genie CLA 2020-06-03 17:24:26 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 11 Eclipse Genie CLA 2022-12-07 12:46:33 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.