Bug 177796 - [preferences] Add new options to 'code formatter' to expose constant from bug 20793
Summary: [preferences] Add new options to 'code formatter' to expose constant from bug...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M7   Edit
Assignee: Benno Baumgartner CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 20793
Blocks:
  Show dependency tree
 
Reported: 2007-03-16 13:19 EDT by Olivier Thomann CLA
Modified: 2007-04-24 12:41 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (5.16 KB, patch)
2007-03-16 13:19 EDT, Olivier Thomann CLA 		no flags Details | Diff
Proposed fix (6.92 KB, patch)
2007-04-23 14:37 EDT, Olivier Thomann CLA 		no flags Details | Diff
fix (9.18 KB, patch)
2007-04-24 12:35 EDT, Benno Baumgartner CLA 		no flags Details | Diff
fix (8.06 KB, patch)
2007-04-24 12:40 EDT, Benno Baumgartner CLA 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2007-03-16 13:19:22 EDT 
Once bug 20793 is fixed, the new constant needs to be exposed in the code formatter preference page.
Comment 1 Olivier Thomann CLA 2007-03-16 13:19:55 EDT 
Created attachment 61130 [details]
Proposed fix
Comment 2 Dani Megert CLA 2007-03-17 08:21:09 EDT 
See my comment in bug 20793,18
Comment 3 Dani Megert CLA 2007-03-17 08:22:07 EDT 
Damn bugzilla. It's bug 20793 comment 18
Comment 4 Martin Aeschlimann CLA 2007-03-19 05:25:19 EDT 
I agree with Dani with the idea that the option should better be placed on the 'Comments' page. So far we have not mixed comments and code settings and the Comment page already contains options like 'Line width' and 'Remove blank lines'.
Comment 5 Olivier Thomann CLA 2007-04-23 14:37:16 EDT 
Created attachment 64641 [details]
Proposed fix

You need the patch from bug 20793 to get it to work.
You might want to rephrase the messages not to use "never" and reverse the value of the option for the display.
Comment 6 Benno Baumgartner CLA 2007-04-24 12:35:31 EDT 
Created attachment 64761 [details]
fix
Comment 7 Benno Baumgartner CLA 2007-04-24 12:40:34 EDT 
Created attachment 64763 [details]
fix

Ooops, why did you remove header from the block masters? Can't a block comment not be a header comment?
Comment 8 Benno Baumgartner CLA 2007-04-24 12:41:58 EDT 
fixed > I20070417-0800