Bug 177761 - Migration of Call Hierarchy to proposed DAO framework
Summary: Migration of Call Hierarchy to proposed DAO framework
Status: NEW
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-16 10:45 EDT by Jason Montojo CLA
Modified: 2020-09-04 15:25 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Montojo CLA 2007-03-16 10:45:01 EDT 
This bug is intended to discuss concerns about the proposed Call Hierarchy service that arose from the March 15 2007 indexer conference call (http://wiki.eclipse.org/index.php/CDT/calls/IndexingMar2007_1).
Comment 1 Jason Montojo CLA 2007-03-16 10:47:31 EDT 
Hi Markus,

You mentioned some concerns about the way the Call Hierarchy service was refactored in the remote prototype posted in bug 158975.  Can you please reiterate those concerns?

Thanks
Comment 2 Markus Schorn CLA 2007-03-19 05:41:45 EDT 
Here are some things that make life easier in CDT:
* The call-hierarchy service should be an abstact class rather than an 
  interface. This way the API can be evolved in a binary compatible manner 
  later on.
* The call-hierarchy should not use a separate service to resolve the editor
  position to a definition. The call-hierarchy needs to do this differently 
  from how navigation does this.
* The local implementation must reside in the UI-plugin. This is because 
  resolving ambiguities may need user-interaction. 
* All classes that are made public must be java-doced.

Please no longer refer to the patch from bug 158975, it contains too many different things and does not apply for large parts. Rather than that, lets discuss the API (just a few files) here first.