Bug 177247 - PDE Build should enforce <requires> section of feature.xml
Summary: PDE Build should enforce <requires> section of feature.xml
Status: NEW
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-13 20:40 EDT by David Olsen CLA
Modified: 2022-11-19 20:32 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Olsen CLA 2007-03-13 20:40:30 EDT
PDE Build enforces any plugin dependencies in a plugin's MANIFEST.MF or plugin.xml.  If the target plugin can't be found, then PDE Build reports an error message and stops the build.

The same thing should happen with the dependencies in the <requires> section of a feature.xml.  Currently those dependencies are ignored at build time.  As a result, those dependencies can grow stale over time.  As far as I know, the only code that uses those dependencies is the Update Manager.  Checking those dependencies only when doing install testing is too late.  Checking those dependencies at build time (much earlier in the development process) would catch problems sooner when they are easier to fix.
Comment 1 Andrew Niefer CLA 2009-02-04 11:03:37 EST
We should think about this in the context of p2

Bug 263568 comment #3:
> This seem strange to me, as requires != optional.  I guess I don't see the
> distinction between "includes" and "requires" when it comes to product build
> and repo generation.  IMHO, if I'm starting with the SDK as my base, include
> the SDK in my product, ECF should be populated in my repo created during the
> product build and therefore be available to the director, as it's required.

You are right, and this is mostly just that PDE/Build has not yet fully caught up to the brave new world that is p2.  However, I can also see an argument that product builds (productBuild.xml) should treat requires as includes. 

Comment 2 Lars Vogel CLA 2018-12-03 09:12:15 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 3 Lars Vogel CLA 2018-12-03 09:13:19 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 4 Eclipse Genie CLA 2020-11-28 13:17:27 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 5 Eclipse Genie CLA 2022-11-19 20:32:17 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.