Bug 177197 - Scripting event tags are reported as HTML_DEFAULT instead of a SCRIPT partition type
Summary: Scripting event tags are reported as HTML_DEFAULT instead of a SCRIPT partiti...
Status: VERIFIED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.0 M3   Edit
Assignee: Nitin Dahyabhai CLA
QA Contact: David Williams CLA
URL:
Whiteboard:
Keywords: api, core
Depends on:
Blocks:
 
Reported: 2007-03-13 15:49 EDT by Bradley Childs CLA
Modified: 2007-11-13 20:42 EST (History)
3 users (show)

See Also:

Attachments
Patch for StructuredTextPartitionerForHTML to include SCRIPT partitioning of EVENT attribute tags. (3.90 KB, patch)
2007-03-13 15:54 EDT, Bradley Childs CLA 		no flags Details | Diff
alternate patch (6.56 KB, patch)
2007-10-24 05:40 EDT, Nitin Dahyabhai CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bradley Childs CLA 2007-03-13 15:49:07 EDT 
The scripting event tags attribute values as defined at:
http://www.w3.org/TR/html4/interact/scripts.html#events
are erroneously reported as HTML_DEFAULT by StructuredTextPartitionerForHTML.
Comment 1 Bradley Childs CLA 2007-03-13 15:54:26 EDT 
Created attachment 60722 [details]
Patch for StructuredTextPartitionerForHTML to include SCRIPT partitioning of EVENT attribute tags.

Patch for StructuredTextPartitionerForHTML to include fix SCRIPT partitioning of EVENT tags attribute value text region.
Comment 2 Nitin Dahyabhai CLA 2007-10-24 05:40:42 EDT 
Created attachment 81041 [details]
alternate patch

The original patch would end up creating too many garbage strings, I think, with all of those substrings being used.  This patch updates it slightly to do a character array comparison in the partitioner if possible.  I tried long and hard to make the comparison in the parser's region factory so that the partitioner could just check the text region implementation class, but it became too big a change to also work in JSP files.  This one's actually a compromise between the the original and my own first pass.
Comment 3 Nitin Dahyabhai CLA 2007-10-24 05:49:59 EDT 
Released for M3.
Comment 4 Amy Wu CLA 2007-11-13 20:42:19 EST 
verified using wtp3.0M3 20071111084533 sdk

except i found 4 tag scripting events that are still not considered script partitions.  i opened bug 209737 to track the outstanding issue.