Bug 176971 - [assist] types are computed if TYPE_REF are filterred and JAVADOC_TYPE_REF aren't filtered
Summary: [assist] types are computed if TYPE_REF are filterred and JAVADOC_TYPE_REF ar...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-03-12 05:46 EDT by David Audel CLA
Modified: 2007-03-20 10:52 EDT (History)
0 users

See Also:


Attachments
Proposed fix (2.06 KB, patch)
2007-03-12 05:48 EDT, David Audel CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2007-03-12 05:46:44 EDT
I20070306-1200

When the completion location isn't inside a javadoc, types are computed if TYPE_REF are filterred and JAVADOC_TYPE_REF aren't filtered.
Comment 1 David Audel CLA 2007-03-12 05:48:44 EDT
Created attachment 60539 [details]
Proposed fix
Comment 2 David Audel CLA 2007-03-12 05:50:57 EDT
Released for 3.3M6.
Comment 3 Maxime Daniel CLA 2007-03-20 10:52:39 EDT
Discussed the problem with David. In fact, the problem is not observable from the outside (except that performances are badly hit), and could be summarized as: before the fix, in the described context, types were computed, then filtered out late in the process; after the fix, the fact we do not need types is acknowledged early, types are not computed (nor filtered at the end of the process).
The verification must hence rely on code inspection.

Verified for 3.3 M6 using v_744.