Bug 1763 - Add Filter button disable until something to add (1GLE2J4)
Summary: Add Filter button disable until something to add (1GLE2J4)
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Darin Swanson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:18 EDT by Darin Swanson CLA
Modified: 2001-10-31 15:07 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Swanson CLA 2001-10-10 22:18:55 EDT 
DS (10/10/2001 11:25:56 AM)
	The "Add Filter" button of the step filtering is always enabled.
	Should only be enabled when there is some text in the text area.

NOTES:
Comment 1 Darin Wright CLA 2001-10-15 11:52:55 EDT 
In consideration with CM's comments about layout.
Comment 2 Joe Szurszewski CLA 2001-10-19 18:55:21 EDT 
It would be nice if we instead of opening a dialog just to capture the filter 
string, we could do in place editing in the table viewer.  Will investigate.
Comment 3 DJ Houghton CLA 2001-10-24 06:40:11 EDT 
PRODUCT VERSION:
203++
Comment 4 Joe Szurszewski CLA 2001-10-29 18:56:53 EST 
Implemented in-place editing of new filters.  The usual keystrokes apply to 
such editing, CR commits change, ESC aborts.  Carolyn, what do you think?
Comment 5 Joe Szurszewski CLA 2001-10-29 18:57:08 EST 
Fixed.
Comment 6 Carolyn MacLeod CLA 2001-10-30 10:12:12 EST 
I'm not sure what I think. At first guess it seems like overkill,
and I don't know what the "Add new" mechanism looks like now.
Did you keep the "add package/type" dialogs?
Those helped the user by providing a list to select from.
I will have to try it to know for sure.
Comment 7 Darin Wright CLA 2001-10-31 15:07:46 EST 
Verified - available in next build. I like the layout/in place addition.