Bug 176229 - Move CElementLabels to non-UI and public place
Summary: Move CElementLabels to non-UI and public place
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 4.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.0 RC0   Edit
Assignee: Anton Leherbauer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-03-02 14:50 EST by Gerhard Schaber CLA
Modified: 2008-06-20 11:27 EDT (History)
1 user (show)

See Also:

Attachments
A patch splitting UI and non-UI parts of CElementLabels (49.80 KB, patch)
2007-03-02 15:00 EST, Gerhard Schaber CLA 		no flags Details | Diff
A patch against HEAD, including client code fixes (77.50 KB, patch)
2007-03-02 15:32 EST, Gerhard Schaber CLA 		no flags Details | Diff
A patch against HEAD, including javadoc for public methods, and client code changes (81.18 KB, patch)
2007-04-20 08:46 EDT, Gerhard Schaber CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gerhard Schaber CLA 2007-03-02 14:50:42 EST 
Build ID: I20061214-1445

Steps To Reproduce:
CElementLabels is in a UI package, but may be used in non-UI code, and outside CDT.

More information:
Comment 1 Gerhard Schaber CLA 2007-03-02 15:00:43 EST 
Created attachment 60202 [details]
A patch splitting UI and non-UI parts of CElementLabels

The patch is against 4.0 HEAD as of 2007-03-02. It can be applied as it is, however in a next step, warnings of client code must be fixed (static methods and fields of CElementBaseLabels must be accessed directly).
Comment 2 Gerhard Schaber CLA 2007-03-02 15:32:34 EST 
Created attachment 60206 [details]
A patch against HEAD, including client code fixes
Comment 3 Anton Leherbauer CLA 2007-03-22 07:31:29 EDT 
Could you rework the patch so that only the minimal set of methods is exposed as public API (basically only getElementLabel())?
And please add/fix javadoc of the remaining public methods/fields.
Thanks!
Comment 4 Gerhard Schaber CLA 2007-04-20 08:46:41 EDT 
Created attachment 64420 [details]
A patch against HEAD, including javadoc for public methods, and client code changes
Comment 5 Anton Leherbauer CLA 2007-04-20 10:48:38 EDT 
Applied to HEAD. I removed method CElementBaseLabels.getTextLabel(Object, int). It does not look like good API. Hope that's OK.