Bug 176216 - [api] FTP sould provide API to allow clients register their own FTPListingParser
Summary: [api] FTP sould provide API to allow clients register their own FTPListingParser
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Javier Montalvo Orús CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 176215 169610
  Show dependency tree
 
Reported: 2007-03-02 13:37 EST by Martin Oberhuber CLA
Modified: 2012-05-23 17:47 EDT (History)
0 users

See Also:


Attachments
Patch providing extension point for parsers and implementations for improved VMS and WinNT parsing (47.87 KB, patch)
2007-04-17 08:09 EDT, Javier Montalvo Orús CLA
mober.at+eclipse: iplog-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-03-02 13:37:39 EST
One of the biggest benefits of Jakarta Commons/Net is the framework for custom FTP Listing parsers. We should not hide this inside our implementation, but provide API (or an extension point?) to allow clients register their own listing parsers.

Use cases for this include VxWorks, which should be moved out of the core implemenation and use the provided API instead (bug 176215);
UNIX/Windows mismatches (bug 169610); and servers using a numerical date format
(http://dev.eclipse.org/mhonarc/lists/dsdp-tm-dev/msg00905.html)

The way how the current vxworks contribution is done (overriding the parser) could serve as a helper when defining the API.
Comment 1 Martin Oberhuber CLA 2007-04-03 10:18:48 EDT
From Javier: 
It would be easiest to extend the parsers using an extension point and a property to select the parser to be used (similar as the FTP active/passive mode). 
This solution would also fix bug 169610 as it could be possible forcing a specific parser rather than leaving the FTP engine to guess it. 

With this solution, I think the bug could be fixed for the next milestone
Comment 2 Javier Montalvo Orús CLA 2007-04-17 08:09:52 EDT
Created attachment 64021 [details]
Patch providing extension point for parsers and implementations for improved VMS and WinNT parsing
Comment 3 Javier Montalvo Orús CLA 2007-04-17 09:36:42 EDT
Martin,

Could you check if after applying the patch you are able to add the VxWorks FTP parser extension ?
It may give an idea on how easy/diificult is providing new parsers using the extension point.
Comment 4 Javier Montalvo Orús CLA 2007-05-10 08:06:31 EDT
Custom listing parsers can be added though the extension point org.eclipse.rse.subsystems.files.ftp.ftpFileEntryParser
Comment 5 Martin Oberhuber CLA 2008-08-13 13:18:45 EDT
[target cleanup] 2.0 M7 was the original target milestone for this bug
Comment 6 Martin Oberhuber CLA 2012-05-23 17:47:36 EDT
Comment on attachment 64021 [details]
Patch providing extension point for parsers and implementations for improved VMS and WinNT parsing

iplog- since Javier became committer in 2006 already:
http://dev.eclipse.org/mhonarc/lists/dsdp-tm-dev/msg00375.html