Bug 175171 - Remove WTP Internet Preferences (see bug 154100)
Summary: Remove WTP Internet Preferences (see bug 154100)
Status: CLOSED FIXED
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: wst.ws (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0 M6   Edit
Assignee: Peter Moogk CLA
QA Contact: Chris Brealey CLA
URL:
Whiteboard:
Keywords:
: 178800 (view as bug list)
Depends on: 154100
Blocks:
  Show dependency tree
 
Reported: 2007-02-22 14:23 EST by Chris Brealey CLA
Modified: 2017-10-11 16:11 EDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Brealey CLA 2007-02-22 14:23:20 EST
Assuming RFE bug 154100 complete with proxy management and Authenticator support continues unabated into Eclipse 3.3, we will need to remove the org.eclipse.wst.internet.proxy plugin.
Comment 1 Chris Brealey CLA 2007-02-22 15:07:33 EST
Targetted to WTP 2.0 M6. Added Michael and David as presumed interested parties.
Comment 2 Chris Brealey CLA 2007-03-14 09:05:35 EDT
Peter,
none of the Web service plugins [1] import org.eclipse.wst.internet.proxy, therefore, removing the plugin should not cause any specific damage to the Web services platform. Plugin org.eclipse.wst.ws.explorer refers directly to the JDK system properties. Since the properties should be initialized long before the WSE gets launched by a user, the WSE shouldn't feel a thing, however, please do test it after you've removed org.eclipse.wst.internet.proxy.

[1] Plugins searched

org.eclipse.jst.ws
org.eclipse.jst.ws.axis.consumption.core
org.eclipse.jst.ws.axis.consumption.ui
org.eclipse.jst.ws.axis.creation.ui
org.eclipse.jst.ws.consumption
org.eclipse.jst.ws.consumption.ui
org.eclipse.jst.ws.creation.ejb.ui
org.eclipse.jst.ws.creation.ui
org.eclipse.jst.ws.uddiregistry
org.eclipse.jst.ws.ui
org.eclipse.wst.command.env
org.eclipse.wst.command.env.core
org.eclipse.wst.command.env.ui
org.eclipse.wst.common.environment
org.eclipse.wst.internet.cache
org.eclipse.wst.internet.proxy
org.eclipse.wst.ws
org.eclipse.wst.ws.explorer
org.eclipse.wst.ws.parser
org.eclipse.wst.ws.ui
Comment 3 Chris Brealey CLA 2007-03-22 10:39:41 EDT
*** Bug 178800 has been marked as a duplicate of this bug. ***
Comment 4 Peter Moogk CLA 2007-03-22 15:44:12 EDT
The fix for this defect has been completed.  The following was changed:

1) org.eclipse.wst.common_ui.feature was updated to remove entries for:
   - org.eclipse.wst.internet.proxy
   - org.eclipse.wst.internet.proxy.infopop
   The changes to this feature were committed and released under version 
   v200703221921

2) org.eclipse.wst.internet.proxy was removed from the wst-common-ui.map file.

3) org.eclipse.wst.internet.proxy.infopop was removed from the wst-doc.map file.
Comment 5 David Williams CLA 2007-03-25 15:48:44 EDT
What to do with the component.xml file in 
org.eclipse.wst.internet.monitor.core?

Did this plugin have an API that we need to be concerned about? 
That is, concerned about providing at least migration instructions, 
if not leave some "deprecated" version of the API's in place, to 
allow people to migrate slowly? 

Did you check the adopter scan data?

I believe too, that JSF pre-req'd this bundle. Not sure how it was used, 
of if/when they have migrated. 

Comment 6 David Williams CLA 2007-03-25 15:51:47 EDT
Also, there will be some documentation implications for this change. Some doc removed from WTP, and some doc added to the platform. 

Kate, adding you as CC so you can fix WTP side, and/or coordinate platform side, if they need it. 

John, I added you as CC so you can coordinate/update any "help for old friends" etc. 

Comment 7 Tim deBoer CLA 2007-03-25 20:25:16 EDT
Plugin had no official API. FWIW, I can easily remove it from the component.xml once Peter/Chris have confirmed that it had no internal API users or respond to David's concerns about migration and deprecation.
Comment 8 Michael Valenta CLA 2007-03-26 09:29:34 EDT
I have entered bug 179295 to document the proxy support in Platform. If someone from WTP could attach the current doc from WTP, that would save me a bit of work.
Comment 9 Peter Moogk CLA 2007-03-27 14:26:00 EDT
The org.eclipse.wst.internet.proxy plugin did have a few of internal classes( 12 to be exact).  None of these classes were part of an internal api.(ie. all were implmentation classes.  Unfortunately, the manifest file did export these classes as internal, so it is possible that someone could have used them.  That said, since these really are internal implementation classes I would recommend that we continue to just delete this plugin.  If some adopter really is using one of these internal classes they can always make a copy of them from the WTP 1.5 stream, since the number of classes is extremely small and self contained.  I searched the adopter usage xml files and didn't find any references to the org.eclipse.wst.internet.proxy plugin, so at least registered adopters shouldn't be affected by this change.

Therefore, I recommend that Tim should remove this plugin from the component.xml file.  
Comment 10 Tim deBoer CLA 2007-03-28 00:38:39 EDT
Change to component.xml released to 2.0 builds.
Comment 11 Chris Brealey CLA 2007-03-29 09:30:36 EDT
Re-resolved as fixed based on changes having been made by Peter (comment 4) and Tim (command 10).
Comment 12 Kathy Chan CLA 2007-06-13 13:31:10 EDT
We are closing down the WTP 2.0 release pretty soon, please verify these defects with the latest WTP 2.0 build.  The WTP 2.0 RC2 driver is available at:

http://download.eclipse.org/webtools/downloads/drops/R2.0/S-2.0RC2-200706050057/
Comment 13 Chris Brealey CLA 2007-06-13 13:40:13 EDT
Verified by inspection of WTP 2.0 RC2 SDK plugins directory. Closed.
Comment 14 Eclipse Genie CLA 2017-10-11 16:11:38 EDT
New Gerrit change created: https://git.eclipse.org/r/108190