Bug 174941 - [api] Get rid of AbstractConnectorServiceManager.updateSubSystems(), sharesSystem()
Summary: [api] Get rid of AbstractConnectorServiceManager.updateSubSystems(), sharesSy...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 170922
  Show dependency tree
 
Reported: 2007-02-21 06:52 EST by Martin Oberhuber CLA
Modified: 2008-08-13 13:17 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-02-21 06:52:56 EST 
There are several issues with AbstractConnectorServiceManager.updateSubSystems():

* Implementation of sharesSystem() (though markup interfaces) cannot work for
  subsystems that re-use an existing ServiceSubSystem but exchange the Service
  and ConnectorService for it: because the existing e.g. FileServiceSubSystem
  would not implement the markup interface e.g. ISshSubSystem

* Parameter Shell is not used but introduces an unnecessary UI dependency
* Javadoc is not understandable and references ald terminology ("System object")
* updateSubSystems() is currently nowhere used

I would vote for getting rid of the entire construct updateSubSystems(), sharesSubSystem(), as well as the subsystem markup interfaces for M6.
Comment 1 David McKnight CLA 2007-03-02 08:58:16 EST 
I've removed the method.  No one actually uses it so it won't be missed.
Comment 2 Martin Oberhuber CLA 2008-08-13 13:17:40 EDT 
[target cleanup] 2.0 M6 was the original target milestone for this bug