Bug 174422 - UnzipperGenerator directs tar contents to wrong directory
Summary: UnzipperGenerator directs tar contents to wrong directory
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-02-16 05:27 EST by Urs Reupke CLA
Modified: 2007-02-16 18:46 EST (History)
1 user (show)

See Also:

Attachments
Patch, replacing the folder name. (980 bytes, patch)
2007-02-16 05:36 EST, Urs Reupke CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Urs Reupke CLA 2007-02-16 05:27:20 EST 
UnzipperGenerator, used among others by package.xml, directs the contents of tar archive to a wrong directory.

"UnzipperGenerator".

Evidence:
If a file is handled as a zip file, it is unzipped twice, once with

<exec executable="unzip" dir="${tempDirectory}/."> 
and again, with slightly different parameters, using
<exec executable="unzip" dir="${tempDirectory}/aix.motif.ppc/.">

For tars, there is are corresponding lines

<exec executable="tar" dir="${tempDirectory}/."> 
and 
<exec executable="tar" dir="${tempDirectory}/.">
where the second call has once again slightly different parameters.

Thus, the root files for the application do not end up in the config specific folder as they should, but instead are extracted to the platform-independent 'eclipse' folder only.

The relevant methods in the source code are UnzipperGenerator.generateUntarRootFiles(String[]) and UnzipperGenerator.generateUnzipRootFiles(String[]).
Comment 1 Urs Reupke CLA 2007-02-16 05:36:19 EST 
Created attachment 59123 [details]
Patch, replacing the folder name.

I have attached a patch file for the UnzipperGenerator. The class now uses the previously created rootFileFolder String as target for the untaroperation, just as witnessed in the generateUnzipRootFiles method.
I believe this to solve the problem.
Comment 2 Andrew Niefer CLA 2007-02-16 18:46:59 EST 
patch released to HEAD