174349 – [open type] Open Type dialog should support '<' and ' ' in combination with camel case

Bug 174349 - [open type] Open Type dialog should support '<' and ' ' in combination with camel case

Summary: [open type] Open Type dialog should support '<' and ' ' in combination with c...

Status:	VERIFIED FIXED

Alias:	None

Product:	JDT
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	3.3
Hardware:	PC Windows XP

Importance:	P3 enhancement (vote)
Target Milestone:	3.3 RC2
Assignee:	Krzysztof Michalski
QA Contact:

URL:
Whiteboard:
Keywords:	polish

Depends on:
Blocks:	175304
	Show dependency tree

Reported:	2007-02-15 13:11 EST by Dani Megert
Modified:	2007-05-25 03:05 EDT (History)
CC List:	4 users (show)

See Also:

Attachments
Enhancement inside patch (2.03 KB, patch) 2007-02-22 09:02 EST, Krzysztof Michalski	no flags	Details \| Diff
Enhancments inside patch (3.79 KB, patch) 2007-02-26 11:51 EST, Krzysztof Michalski	no flags	Details \| Diff
Enchancement with tests inside patch (9.76 KB, patch) 2007-02-27 05:57 EST, Krzysztof Michalski	no flags	Details \| Diff
Fix (6.16 KB, patch) 2007-05-24 14:55 EDT, Szymon Brandys	no flags	Details \| Diff
mylar/context/zip (3.46 KB, application/octet-stream) 2007-05-24 14:55 EDT, Szymon Brandys	no flags	Details
Fix Patch for SearchPattern and SearchPatternAuto (7.18 KB, patch) 2007-05-24 15:17 EDT, Krzysztof Michalski	no flags	Details \| Diff
Fix Patch for FilteredTypesSelectionDialog (3.29 KB, patch) 2007-05-24 15:18 EDT, Krzysztof Michalski	no flags	Details \| Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dani Megert

2007-02-15 13:11:35 EST

3.3 M5

Currently I can use '<' and ' ' to terminate the search string. This however does not work when entering camel case, e.g. 'DP<'

Comment 1 Krzysztof Michalski

2007-02-22 09:02:07 EST

Created attachment 59563 [details]
Enhancement inside patch

Comment 2 Tod Creasey

2007-02-22 13:28:14 EST

Patch released for build>20070222

Comment 3 Tod Creasey

2007-02-23 12:59:06 EST

Rolling back as this is breaking our suites

Comment 4 Tod Creasey

2007-02-23 13:03:28 EST

Patch rolled back for build >20070223

Comment 5 Krzysztof Michalski

2007-02-26 11:51:41 EST

Created attachment 59802 [details]
Enhancments inside patch

Comment 6 Krzysztof Michalski

2007-02-27 05:57:30 EST

Created attachment 59856 [details]
Enchancement with tests inside patch

Patch contains changes for SearchPattern and SearchPatterAuto.

Comment 7 Tod Creasey

2007-03-01 11:59:41 EST

Patch released for build >20070301

Comment 8 Markus Keller

2007-04-30 11:50:32 EDT

Does not work when "<"-terminated camel case pattern is pasted, see explanation in bug 174349 comment 4. Shouldn't ship like this since the behavior is unpredictable.

Comment 9 Markus Keller

2007-05-07 04:33:52 EDT

(In reply to comment #8)
Sorry, wrong reference. Explanation is in bug 184688 comment 4.

Comment 10 Dani Megert

2007-05-16 07:57:18 EDT

I hope this makes it into RC1.

Comment 11 Krzysztof Michalski

2007-05-16 08:28:44 EDT

I removed all changes described in this enhancement. All string ended by '<' or ' ' are treated as exact match string. This enhancement was cause of bug 184688.

Comment 12 Dani Megert

2007-05-18 09:58:35 EDT

This is not fixed.

Comment 13 Tod Creasey

2007-05-22 09:25:04 EDT

Markus is the problem with how this patch works or do you think this is a bad idea in general?

Comment 14 Markus Keller

2007-05-22 09:46:38 EDT

> Markus is the problem with how this patch works or do you think this is a bad
> idea in general?

I think the feature is a good idea, but we can only ship it if it works reliably. I think adapting JDT/Core's SearchPattern is not an option at this time.

A possible workaround for 3.3 would be special code in FilteredTypesSelectionDialog#fillContentProvider(..):
If the pattern is a camelCase pattern with a terminator, then don't call setMatchEverythingMode(true). I have not tested this yet, but I think it should work if ui.dialogs.SearchPattern was changed again to support camelCase in combination with a terminator.
(Note that ui.dialogs.SearchPattern cannot just be reverted to the original fix for bug 174349, since the problematic calls to trim() must not be restored.)

Comment 15 Szymon Brandys

2007-05-24 14:55:42 EDT

Created attachment 68637 [details]
Fix

Comment 16 Szymon Brandys

2007-05-24 14:55:44 EDT

Created attachment 68638 [details]
mylar/context/zip

Comment 17 Krzysztof Michalski

2007-05-24 15:17:25 EDT

Created attachment 68647 [details]
Fix Patch for SearchPattern and SearchPatternAuto

Comment 18 Krzysztof Michalski

2007-05-24 15:18:39 EDT

Created attachment 68650 [details]
Fix Patch for FilteredTypesSelectionDialog

Comment 19 Tod Creasey

2007-05-24 15:31:03 EDT

UI portion released to HEAD. Szymon assures me that this should not have any adverse affect on JDT.

Comment 20 Szymon Brandys

2007-05-24 16:17:06 EDT

The only visible issue is filtering for camel case patterns with a terminator.

Both changes to UI and JDT are necessary to fix the bug. Because we won't be able to commit UI changes tomorrow, we have to do this today.

The issue will be fixed when the JDT patch will be applied.

Comment 21 Markus Keller

2007-05-24 19:57:42 EDT

Thanks, released a slightly modified version of comment 18 to HEAD.

Comment 22 Dani Megert

2007-05-25 03:05:11 EDT

Verified in I20070525-0010. Thanks!