Bug 174189 - [Launcher] Launcher Arguments should have different naming
Summary: [Launcher] Launcher Arguments should have different naming
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: equinox.framework-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-14 11:36 EST by Andrew Niefer CLA
Modified: 2007-02-26 14:39 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Niefer CLA 2007-02-14 11:36:55 EST
With the new launcher work, several new arguments have been added to the launcher.

Every argument consumed by the launcher is one argument that can't be used by an eclipse application.

We should change the naming of the new arguments to distinguish them from other application arguments.  As well, if the launcher must pass information to Java for its own purposes, it should do it by setting system properties.

Currently the new arguments are:
-library          
-suppressErrors
-ini (not yet, but probably coming for bug 149994)

-library is also read by Main, it should be passed into java with -Dorg.eclipse.equinox.launcher.library.

One suggestion is to use -- arguments (--library).
Comment 1 Andrew Niefer CLA 2007-02-21 17:37:27 EST
Simply changing the arguments to start with -- doesn't really solve the problem, as applications could be easily using those arguments.

I suggest using, for example, --launcher-library (or --launcher.library)
The convention for linux seems to be that -- arguments are "long" arguments, generally the normal short arguments have corresponding long ones.

The alternative is to have these arguments specified as vm-args that set properties and the launcher would then scan the vmargs for any that apply to it.

I am leaning towards using the longer arguments mostly because it is a simple change in the code.
Comment 2 Andrew Niefer CLA 2007-02-26 14:10:16 EST
These changes have been made.  The launcher is now using
--launcher.library
--launcher.suppressErrors
--launcher.ini